You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/29 13:08:09 UTC

[GitHub] [trafficserver] traeak opened a new pull request #8479: UnixNetVConnection: add chek for nh in fail block

traeak opened a new pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479


   Ran into this core dump while performing network stress testing.
   
   In UnixNetVConnection::connectUp
   if this fails:
   ```
     if ((res = get_NetHandler(t)->startIO(this)) < 0) {
       goto fail;
     }
   ```
   this->nh is never set. In the fail block check this->nh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] traeak commented on pull request #8479: UnixNetVConnection: add check for nh in fail block

Posted by GitBox <gi...@apache.org>.
traeak commented on pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479#issuecomment-961994408


   Updated to add the "free(t)" (ethread) call in case nh is nullptr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #8479: UnixNetVConnection: add check for nh in fail block

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479#issuecomment-963463065


   Cherry-picked to v9.1.x branch
   Cherry-picked to v9.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] traeak merged pull request #8479: UnixNetVConnection: add check for nh in fail block

Posted by GitBox <gi...@apache.org>.
traeak merged pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] traeak commented on pull request #8479: UnixNetVConnection: add check for nh in fail block

Posted by GitBox <gi...@apache.org>.
traeak commented on pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479#issuecomment-961994408


   Updated to add the "free(t)" (ethread) call in case nh is nullptr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] traeak commented on pull request #8479: UnixNetVConnection: add chek for nh in fail block

Posted by GitBox <gi...@apache.org>.
traeak commented on pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479#issuecomment-956226424


   In tracing through the code the one thing possibly not handled is netevent->free(ethread).
   
   So the code could look like:
   ```
     if (nullptr != nh) {
       nh->free_netevent(this);
     } else {
       this->free(t);
     }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] traeak commented on pull request #8479: UnixNetVConnection: add check for nh in fail block

Posted by GitBox <gi...@apache.org>.
traeak commented on pull request #8479:
URL: https://github.com/apache/trafficserver/pull/8479#issuecomment-961994408


   Updated to add the "free(t)" (ethread) call in case nh is nullptr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org