You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/12/11 21:49:58 UTC
[native-toolchain-CR] Fix prerequisites for building newer Kudu
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14892
Change subject: Fix prerequisites for building newer Kudu
......................................................................
Fix prerequisites for building newer Kudu
Newer versions of Kudu require Java 8 to build, so all images need
to use Java 8. This was already true for everything except Debian8.
This switches the Debian8 docker container to use Java 8. This
required getting openjdk-8-jdk from jessie-backports. (Good blog
post on this: https://www.lucas-nussbaum.net/blog/?p=947 )
This adds a validation step to verify that java has version
1.8.0.
Separately, Kudu's thirdparty compilation of curl requires being
able to find krb5-config on the PATH. On SLES12, krb5-config
is in /usr/lib/mit/bin, so this adds that directory to PATH if
it exists.
Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
---
M docker/all/assert-dependencies-present.py
A docker/debian/8/99no-check-valid-until
M docker/debian/8/sources.list
M docker/debian8.df
M source/kudu/build.sh
5 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/92/14892/1
--
To view, visit http://gerrit.cloudera.org:8080/14892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
Gerrit-Change-Number: 14892
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] Fix prerequisites for building newer Kudu
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14892 )
Change subject: Fix prerequisites for building newer Kudu
......................................................................
Patch Set 1: Verified+1
Docker build of images succeeded. Docker toolchain build succeeded (even with latest Kudu).
--
To view, visit http://gerrit.cloudera.org:8080/14892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
Gerrit-Change-Number: 14892
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 01:10:18 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Fix prerequisites for building newer Kudu
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14892 )
Change subject: Fix prerequisites for building newer Kudu
......................................................................
Fix prerequisites for building newer Kudu
Newer versions of Kudu require Java 8 to build, so all images need
to use Java 8. This was already true for everything except Debian8.
This switches the Debian8 docker container to use Java 8. This
required getting openjdk-8-jdk from jessie-backports. (Good blog
post on this: https://www.lucas-nussbaum.net/blog/?p=947 )
This adds a validation step to verify that java has version
1.8.0.
Separately, Kudu's thirdparty compilation of curl requires being
able to find krb5-config on the PATH. On SLES12, krb5-config
is in /usr/lib/mit/bin, so this adds that directory to PATH if
it exists.
Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
Reviewed-on: http://gerrit.cloudera.org:8080/14892
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M docker/all/assert-dependencies-present.py
A docker/debian/8/99no-check-valid-until
M docker/debian/8/sources.list
M docker/debian8.df
M source/kudu/build.sh
5 files changed, 28 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
Gerrit-Change-Number: 14892
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Fix prerequisites for building newer Kudu
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14892 )
Change subject: Fix prerequisites for building newer Kudu
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4e776ea715ad7d13a978bc69c898261c1582384
Gerrit-Change-Number: 14892
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 23:23:19 +0000
Gerrit-HasComments: No