[jira] Commented: (MPEAR-17) plugin could generate more elements in application.xml

[ji...@codehaus.org]

The following comment has been added to this issue:

     Author: Morten Kristiansen
    Created: Wed, 26 Jan 2005 3:45 PM
       Body:
We have solved this differently in our project:

We develop our application in WSAD for deployment on WAS, using J2EE security (hence security roles in application.xml). I think the connection between the standard application.xml and the WAS' vendor specific .xmi files are rather tight, so only generating the security roles might not work (because of numeric id reference between the files, generated in IDE).

Our solution is that we override the standard goal in EAR plugin that generates application.xml and copy security roles from the original application.xml file (if it exist and contains security roles of course).

I'll be glad to submit a patch if you're interessted.
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPEAR-17?page=comments#action_29309

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPEAR-17

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-17
    Summary: plugin could generate more elements in application.xml
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin

   Assignee: 
   Reporter: Charles Crouch

    Created: Fri, 25 Jun 2004 4:25 PM
    Updated: Wed, 26 Jan 2005 3:45 PM
Environment: maven-ear-plugin-1.5, maven-1.0-rc3, windows XP SP1

Description:
The EAR plugin can generate an application.xml containing display-name and module elements but it lacks several others, i.e.

1) application/description
2) application/security-role/role-name

The changes described below are quite small and enable the creation of the above elements by specifying more properties, e.g.

1) maven.ear.appxml.description=Product ${pom.groupId}, version ${pom.currentVersion}
2) maven.ear.appxml.securityRoles=UserRole, AdminRole

The changes to the plugin.jelly, positioned correctly, would be:

1)     <j:set var="applicationDescription" value="${maven.ear.appxml.description}"/>
	<j:if test="${!empty(applicationDescription)}">
	   <x:element name="description">${maven.ear.appxml.description}</x:element>
        </j:if >
     
2)       <j:set var="securityRoles" value="${maven.ear.appxml.securityRoles}"/>
	 <j:if test="${!empty(securityRoles)}">
	 	<util:tokenize var="roles" delim="," trim="true">${maven.ear.appxml.securityRoles}</util:tokenize>
	 	<j:forEach var="role" items="${roles}">
	 		<x:element name="security-role">
	 			<x:element name="role-name">${role.trim()}</x:element>
	                 </x:element>
	 	</j:forEach>
	 </j:if > 
   


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org