You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/02/18 06:35:49 UTC
Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs
-----
core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 3c2f67ea75548035911addfb40907a16a980d695
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/#review120743
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Feb. 25, 2016, 12:04 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43711/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 12:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2843
> https://issues.apache.org/jira/browse/SQOOP-2843
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Enable SSL/TLS for API calls
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
> dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
> test/pom.xml 1e88b34a684709e7a0ad8a71480e7bad37a94398
> test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
> test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
> test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
> test/src/test/resources/connector-loading-tests-suite.xml c03fb4f008ec75a65efbd6ad6c4eb33d37099124
>
> Diff: https://reviews.apache.org/r/43711/diff/
>
>
> Testing
> -------
>
> passing integration tests
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
(Updated Feb. 25, 2016, 12:04 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/pom.xml 1e88b34a684709e7a0ad8a71480e7bad37a94398
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml c03fb4f008ec75a65efbd6ad6c4eb33d37099124
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 11:07 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/pom.xml 134bca1d619e9a73ca9f1b44beb166960ef84e52
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
> On Feb. 19, 2016, 3:41 p.m., Jarek Cecho wrote:
> > test/src/test/resources/connector-loading-tests-suite.xml, lines 21-31
> > <https://reviews.apache.org/r/43711/diff/4/?file=1254900#file1254900line21>
> >
> > Out of curiosity: Why this module change?
the ssltest needs to create its own instance of the sqoop server. by leaving the test inside the "server" test suite, I run into issues due to the suite shared instance of sqoop2 server that is running to support those tests (from the sqoopinfrastructureprovider). The ConnectorLoadingTests suite is different than our other suites in that it does not have a shared instance of sqoop server (all of the connectorloadingtests involve launch the server with different properites).
Since we do something similar to the ConnectorLoadingTests in the ssltest I decided to move the ssltest to that test suite. and since the ssltest has nothing to do with connectorloading i thought it would be appropriate to rename the suite to reflect what all of the tests had in common.
> On Feb. 19, 2016, 3:41 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/security/SecurityConstants.java, lines 192-201
> > <https://reviews.apache.org/r/43711/diff/4/?file=1254889#file1254889line192>
> >
> > Nit: It seems that we either use dot to separate names or underscores rather then just removing spaces. Perhaps we should stay consistent?
will do
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/#review119889
-----------------------------------------------------------
On Feb. 18, 2016, 6:45 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43711/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2843
> https://issues.apache.org/jira/browse/SQOOP-2843
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Enable SSL/TLS for API calls
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
> dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
> test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
> test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
> test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
> test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
>
> Diff: https://reviews.apache.org/r/43711/diff/
>
>
> Testing
> -------
>
> passing integration tests
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 19, 2016, 3:41 p.m., Jarek Cecho wrote:
> > test/src/test/resources/connector-loading-tests-suite.xml, lines 21-31
> > <https://reviews.apache.org/r/43711/diff/4/?file=1254900#file1254900line21>
> >
> > Out of curiosity: Why this module change?
>
> Abraham Fine wrote:
> the ssltest needs to create its own instance of the sqoop server. by leaving the test inside the "server" test suite, I run into issues due to the suite shared instance of sqoop2 server that is running to support those tests (from the sqoopinfrastructureprovider). The ConnectorLoadingTests suite is different than our other suites in that it does not have a shared instance of sqoop server (all of the connectorloadingtests involve launch the server with different properites).
>
> Since we do something similar to the ConnectorLoadingTests in the ssltest I decided to move the ssltest to that test suite. and since the ssltest has nothing to do with connectorloading i thought it would be appropriate to rename the suite to reflect what all of the tests had in common.
ACK make sense.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/#review119889
-----------------------------------------------------------
On Feb. 18, 2016, 6:45 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43711/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2843
> https://issues.apache.org/jira/browse/SQOOP-2843
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Enable SSL/TLS for API calls
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
> dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
> test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
> test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
> test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
> test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
>
> Diff: https://reviews.apache.org/r/43711/diff/
>
>
> Testing
> -------
>
> passing integration tests
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/#review119889
-----------------------------------------------------------
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java (lines 192 - 201)
<https://reviews.apache.org/r/43711/#comment181282>
Nit: It seems that we either use dot to separate names or underscores rather then just removing spaces. Perhaps we should stay consistent?
test/src/test/resources/connector-loading-tests-suite.xml (lines 21 - 31)
<https://reviews.apache.org/r/43711/#comment181283>
Out of curiosity: Why this module change?
- Jarek Cecho
On Feb. 18, 2016, 6:45 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43711/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2843
> https://issues.apache.org/jira/browse/SQOOP-2843
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Enable SSL/TLS for API calls
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
> dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
> test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
> test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
> test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
> test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
> test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
>
> Diff: https://reviews.apache.org/r/43711/diff/
>
>
> Testing
> -------
>
> passing integration tests
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 6:45 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 6:36 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine
Re: Review Request 43711: Sqoop2: Enable SSL/TLS for API calls
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43711/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 5:41 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2843
https://issues.apache.org/jira/browse/SQOOP-2843
Repository: sqoop-sqoop2
Description
-------
Sqoop2: Enable SSL/TLS for API calls
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3aa7bc6f4fa2ddf94ce436bce5d07ceb72
Diff: https://reviews.apache.org/r/43711/diff/
Testing
-------
passing integration tests
Thanks,
Abraham Fine