You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/05/19 14:37:59 UTC

[GitHub] [orc] czxrrr commented on a change in pull request #701: ORC-800: Add `selectMaps` API

czxrrr commented on a change in pull request #701:
URL: https://github.com/apache/orc/pull/701#discussion_r635306365



##########
File path: c++/src/Reader.hh
##########
@@ -96,6 +96,9 @@ namespace orc {
     // For each child of type, select it if one of its children
     // is selected.
     bool selectParents(std::vector<bool>& selectedColumns, const Type& type);
+
+    // For selected map type, select its children, key and value
+    void selectMaps(std::vector<bool>& selectedColumns, const Type& type);

Review comment:
       List won't have such issues, because list only has one child. Parent and Child have to be both selected or both unselected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org