You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/16 02:12:45 UTC
[jira] [Commented] (CB-9669) Browser exec should have more
failsafes
[ https://issues.apache.org/jira/browse/CB-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746550#comment-14746550 ]
ASF GitHub Bot commented on CB-9669:
------------------------------------
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/18
CB-9669 Browser exec should have more failsafes
This makes the browser exec methods consistent with other js-only platforms.
CallbackID's are used, callbacks can be 'kept' and missing proxies are logged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-browser CB-9669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-browser/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 826d18d99a3f9b8d60e7d5a7c05bedb14ab055cd
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-15T23:58:26Z
More verbose execution model to match other platforms
commit 22158b234480a36a12686ce369af7fa62d587ea5
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-16T00:10:02Z
fix lint error
----
> Browser exec should have more failsafes
> ---------------------------------------
>
> Key: CB-9669
> URL: https://issues.apache.org/jira/browse/CB-9669
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: Jesse MacFadyen
> Assignee: Jesse MacFadyen
>
> Considering the likelihood of a plugin not implementing an api on browser, it would be good to have the exec proxy output a message about the missing api and call the error handler, instead of failing outright.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org