You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2009/06/17 16:34:07 UTC
[jira] Created: (SOLR-1226) XPathEntityProcessor should resolve xsl
references within Solr's configuration
XPathEntityProcessor should resolve xsl references within Solr's configuration
------------------------------------------------------------------------------
Key: SOLR-1226
URL: https://issues.apache.org/jira/browse/SOLR-1226
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 1.4
Reporter: David Smiley
Priority: Minor
The XPathEntityProcessor forces me to use a URL to specify where my XSL file is. if it is not a URL, what it should do is attempt to resolve it from Solr's configuration via SolrCore.getREsourceLoader(). I have attached a patch which does this.
Note: it is not clear in the DIH what the concurrency model is and thus I was not certain that XPathEntityProcessor needs to be thread-safe or not. So just in case I cached the XSLT Transformer in a thread-safe manner using a ThreadLocal. If DIH committers know that it doesn't have to be thread-safe then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1226) XPathEntityProcessor should resolve
xsl references within Solr's configuration
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul reassigned SOLR-1226:
--------------------------------
Assignee: Noble Paul
> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
> Key: SOLR-1226
> URL: https://issues.apache.org/jira/browse/SOLR-1226
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file is. if it is not a URL, what it should do is attempt to resolve it from Solr's configuration via SolrCore.getREsourceLoader(). I have attached a patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was not certain that XPathEntityProcessor needs to be thread-safe or not. So just in case I cached the XSLT Transformer in a thread-safe manner using a ThreadLocal. If DIH committers know that it doesn't have to be thread-safe then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1226) XPathEntityProcessor should resolve xsl
references within Solr's configuration
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated SOLR-1226:
-------------------------------
Attachment: SOLR-1226.patch
> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
> Key: SOLR-1226
> URL: https://issues.apache.org/jira/browse/SOLR-1226
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: David Smiley
> Priority: Minor
> Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file is. if it is not a URL, what it should do is attempt to resolve it from Solr's configuration via SolrCore.getREsourceLoader(). I have attached a patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was not certain that XPathEntityProcessor needs to be thread-safe or not. So just in case I cached the XSLT Transformer in a thread-safe manner using a ThreadLocal. If DIH committers know that it doesn't have to be thread-safe then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1226) XPathEntityProcessor should resolve
xsl references within Solr's configuration
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751838#action_12751838 ]
Shalin Shekhar Mangar commented on SOLR-1226:
---------------------------------------------
Looks like we forgot about this issue.
David, DIH is single-threaded (for now) so the ThreadLocal is not neccessary. A unit test will also be good to have.
> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
> Key: SOLR-1226
> URL: https://issues.apache.org/jira/browse/SOLR-1226
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file is. if it is not a URL, what it should do is attempt to resolve it from Solr's configuration via SolrCore.getREsourceLoader(). I have attached a patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was not certain that XPathEntityProcessor needs to be thread-safe or not. So just in case I cached the XSLT Transformer in a thread-safe manner using a ThreadLocal. If DIH committers know that it doesn't have to be thread-safe then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1226) XPathEntityProcessor should resolve xsl
references within Solr's configuration
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-1226:
----------------------------------------
Fix Version/s: 1.5
> XPathEntityProcessor should resolve xsl references within Solr's configuration
> ------------------------------------------------------------------------------
>
> Key: SOLR-1226
> URL: https://issues.apache.org/jira/browse/SOLR-1226
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1226.patch
>
>
> The XPathEntityProcessor forces me to use a URL to specify where my XSL file is. if it is not a URL, what it should do is attempt to resolve it from Solr's configuration via SolrCore.getREsourceLoader(). I have attached a patch which does this.
> Note: it is not clear in the DIH what the concurrency model is and thus I was not certain that XPathEntityProcessor needs to be thread-safe or not. So just in case I cached the XSLT Transformer in a thread-safe manner using a ThreadLocal. If DIH committers know that it doesn't have to be thread-safe then some of this code can be simplified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.