You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/09 19:58:09 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4396: make
kafka version number controlled by config number
codecov-io edited a comment on issue #4396: make kafka version number controlled by config number
URL: https://github.com/apache/incubator-pinot/pull/4396#issuecomment-507952318
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=h1) Report
> Merging [#4396](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/33f583b2a84a8a22143a26c9cc6b80dc2a81563c?src=pr&el=desc) will **increase** coverage by `9.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4396 +/- ##
============================================
+ Coverage 55.7% 65.25% +9.54%
Complexity 20 20
============================================
Files 1066 1068 +2
Lines 55403 55557 +154
Branches 7894 7910 +16
============================================
+ Hits 30865 36255 +5390
+ Misses 22150 16733 -5417
- Partials 2388 2569 +181
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gment/index/readers/ImmutableDictionaryReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvSW1tdXRhYmxlRGljdGlvbmFyeVJlYWRlci5qYXZh) | `90.47% <0%> (-3.79%)` | `0% <0%> (ø)` | |
| [...inot/core/realtime/impl/RealtimeSegmentConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1JlYWx0aW1lU2VnbWVudENvbmZpZy5qYXZh) | `95.16% <0%> (-1.4%)` | `0% <0%> (ø)` | |
| [...segment/creator/impl/SegmentDictionaryCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50RGljdGlvbmFyeUNyZWF0b3IuamF2YQ==) | `83.64% <0%> (-0.14%)` | `0% <0%> (ø)` | |
| [...g/apache/pinot/common/config/CompletionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0NvbXBsZXRpb25Db25maWcuamF2YQ==) | `54.54% <0%> (ø)` | `0% <0%> (?)` | |
| [.../core/io/util/VarLengthBytesValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby91dGlsL1Zhckxlbmd0aEJ5dGVzVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `79.03% <0%> (ø)` | `0% <0%> (?)` | |
| [...org/apache/pinot/common/config/IndexingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0luZGV4aW5nQ29uZmlnLmphdmE=) | `53.57% <0%> (+0.3%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ator/transform/function/BaseTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQmFzZVRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `29.95% <0%> (+0.42%)` | `0% <0%> (ø)` | :arrow_down: |
| [...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==) | `56.25% <0%> (+0.56%)` | `0% <0%> (ø)` | :arrow_down: |
| [...r/transform/function/ValueInTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vVmFsdWVJblRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `39.2% <0%> (+0.8%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `87.5% <0%> (+0.8%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [324 more](https://codecov.io/gh/apache/incubator-pinot/pull/4396/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=footer). Last update [33f583b...e0f1480](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org