Re: [PR] [CALCITE-6140] Add percentile_rank test on SqlParserTest [calcite]

["caicancai (via GitHub)" <gi...@apache.org>]

caicancai commented on code in PR #3554:
URL: https://github.com/apache/calcite/pull/3554#discussion_r1410012529


##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -784,6 +784,13 @@ protected static SortedSet<String> keywords(@Nullable String dialect) {
         .fails("(?s)Encountered \"\\*\" at .*");
   }
 
+
+  @Test void testPercentile() {
+    sql("SELECT percentile(x, .5) within group (order by 3) from t")
+        .ok("SELECT `PERCENTILE`(`X`, 0.5) WITHIN GROUP (ORDER BY 3)\n"

Review Comment:
   Thank you for your review and reply. I changed test to PERCENT_RANK. pg and sqlserver support it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org