You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/19 07:12:55 UTC

[GitHub] [skywalking-nodejs] wu-sheng commented on a diff in pull request #80: support mongodb@4

wu-sheng commented on code in PR #80:
URL: https://github.com/apache/skywalking-nodejs/pull/80#discussion_r852669761


##########
package.json:
##########
@@ -56,12 +56,12 @@
     "eslint-plugin-header": "^3.1.1",
     "eslint-plugin-prettier": "^4.0.0",
     "express": "^4.17.1",
-    "grpc-tools": "^1.11.1",
     "grpc_tools_node_protoc_ts": "^5.3.0",
+    "grpc-tools": "^1.11.1",
     "ioredis": "^4.27.2",
     "jest": "^26.6.3",
     "lint-staged": "^12.3.2",
-    "mongodb": "^3.6.4",
+    "mongodb": "^4.5.0",

Review Comment:
   I am not sure whether this is a good practise.
   
   @tom-pytel @kezhenxu94 How nodeJS agent controls the versions of plugin supporting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org