[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1590: IGNITE-18625 Sql. Code cleanup. Unmute tests.

["ygerzhedovich (via GitHub)" <gi...@apache.org>]

ygerzhedovich commented on code in PR #1590:
URL: https://github.com/apache/ignite-3/pull/1590#discussion_r1090385567


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void eventsAreFiredWhenIndexesCreatedAndDropped() {
         CompletableFuture<IndexEventParameters> indexCreatedFuture = registerListener(indexManager, IndexEvent.CREATE);
 
         indexManager.createIndexAsync("PUBLIC", "INAME", "TNAME", true, tableIndexChange ->
-                tableIndexChange.convert(HashIndexChange.class).changeColumnNames("C3", "C2")).join();
+                tableIndexChange.convert(HashIndexChange.class).changeColumnNames("C3", "C2")).get();

Review Comment:
   you keep potentially infinity lock.
   Let's use `await(CompletionStage stage)` instead of any 'join', `get`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org