You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/07 19:43:32 UTC
Review Request 27736: Config History: service/group filtered results
should be internally sorted by version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27736/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8196
https://issues.apache.org/jira/browse/AMBARI-8196
Repository: ambari
Description
-------
On dashboard> Config history,
Sorting based on Service Name(or Group Name) should also internal sort based on version.
At present there is no order between the config versions of a service (group).
Diffs
-----
ambari-web/app/mixins/common/table_server_mixin.js 33357ea
Diff: https://reviews.apache.org/r/27736/diff/
Testing
-------
Patch tested manually. Unit tests passed.
Thanks,
Xi Wang
Re: Review Request 27736: Config History: service/group filtered
results should be internally sorted by version
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27736/#review60366
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Nov. 7, 2014, 6:54 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27736/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 6:54 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-8196
> https://issues.apache.org/jira/browse/AMBARI-8196
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On dashboard> Config history,
> Sorting based on Service Name(or Group Name) should also internal sort based on version.
> At present there is no order between the config versions of a service (group).
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/dashboard/config_history_controller.js 4faff54
> ambari-web/app/mixins/common/table_server_mixin.js 33357ea
>
> Diff: https://reviews.apache.org/r/27736/diff/
>
>
> Testing
> -------
>
> Patch tested manually. Unit tests passed.
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 27736: Config History: service/group filtered
results should be internally sorted by version
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27736/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 10:54 a.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8196
https://issues.apache.org/jira/browse/AMBARI-8196
Repository: ambari
Description
-------
On dashboard> Config history,
Sorting based on Service Name(or Group Name) should also internal sort based on version.
At present there is no order between the config versions of a service (group).
Diffs (updated)
-----
ambari-web/app/controllers/main/dashboard/config_history_controller.js 4faff54
ambari-web/app/mixins/common/table_server_mixin.js 33357ea
Diff: https://reviews.apache.org/r/27736/diff/
Testing
-------
Patch tested manually. Unit tests passed.
Thanks,
Xi Wang