You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/23 04:10:25 UTC
[jira] [Commented] (CB-9741) Use Proper Android Internal Storage
API in AudioPlayer
[ https://issues.apache.org/jira/browse/CB-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207810#comment-15207810 ]
ASF GitHub Bot commented on CB-9741:
------------------------------------
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-200146522
Just been testing this in my project, seems to work well. One issue with this PR is that you have deleted a closing bracket on line 510 that should still be present.
Once I fixed that one small thing this PR works perfectly for my project with Android 6.0 and resolved some playback issues I was having that were not present on earlier versions of Android.
I would recommend fixing that one bracket and then merging this too.
> Use Proper Android Internal Storage API in AudioPlayer
> ------------------------------------------------------
>
> Key: CB-9741
> URL: https://issues.apache.org/jira/browse/CB-9741
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
> Environment: Android
> Reporter: Richard B Knoll
> Assignee: Richard B Knoll
> Labels: Android, triaged
>
> In AudioPlayer.java there are a few locations where "/data/data/" is hardcoded as part of the path. That internal storage directory can change on multi-user devices so it should really be accessed using Context.getFilesDir()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org