You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/10/29 18:37:34 UTC

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11817


Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................

[backup] Port keepAlive implementation to KuduBackupRDD

This copies the keepAlive implementation from
KuduRDD over to the KuduBackupRDD.

Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
2 files changed, 28 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11817/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11817/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala:

http://gerrit.cloudera.org:8080/#/c/11817/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala@90
PS2, Line 90: The
Should be lower-case.



-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 19:03:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11817

to look at the new patch set (#2).

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................

[backup] Port keepAlive implementation to KuduBackupRDD

This copies the keepAlive implementation from
KuduRDD over to the KuduBackupRDD.

Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
2 files changed, 28 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11817/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 20:27:24 +0000
Gerrit-HasComments: No

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11817/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala:

http://gerrit.cloudera.org:8080/#/c/11817/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala@113
PS3, Line 113:   private var lastKeepAliveTimeMs = System.currentTimeMillis()
> I guess this applies to the other patch as well; shouldn't we use nanotime?
We could consider that as a follow up change to both.

I am not sure how much as a real world concern that is. Using nanotime is a bit more costly, so there is a little bit of a downside.



-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 21:17:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 1:

I would really like to combine the implementations. The one thing holding us back is the open question about incremental backups impact. It would not be hard to merge.


-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 18:58:43 +0000
Gerrit-HasComments: No

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11817/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala:

http://gerrit.cloudera.org:8080/#/c/11817/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala@113
PS3, Line 113:   private var lastKeepAliveTimeMs = System.currentTimeMillis()
I guess this applies to the other patch as well; shouldn't we use nanotime? Here and below. To avoid being affected by clock changes.



-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 20:43:16 +0000
Gerrit-HasComments: Yes

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................

[backup] Port keepAlive implementation to KuduBackupRDD

This copies the keepAlive implementation from
KuduRDD over to the KuduBackupRDD.

Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Reviewed-on: http://gerrit.cloudera.org:8080/11817
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
2 files changed, 28 insertions(+), 3 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 1:

(1 comment)

I'd ask you to port the test too, but that's even more code duplication. How difficult would it be to combine the RDD implementations at this point?

http://gerrit.cloudera.org:8080/#/c/11817/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala:

http://gerrit.cloudera.org:8080/#/c/11817/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala@90
PS1, Line 90: he
the



-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 18:55:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11817 )

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11817/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala:

http://gerrit.cloudera.org:8080/#/c/11817/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala@90
PS2, Line 90: The
> Should be lower-case.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 20:31:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] [backup] Port keepAlive implementation to KuduBackupRDD

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11817

to look at the new patch set (#3).

Change subject: [backup] Port keepAlive implementation to KuduBackupRDD
......................................................................

[backup] Port keepAlive implementation to KuduBackupRDD

This copies the keepAlive implementation from
KuduRDD over to the KuduBackupRDD.

Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
2 files changed, 28 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/11817/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10d7645781d2b18eb89034e1b4f55045b01ca0da
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>