[jira] [Commented] (THRIFT-4006) Add a removeEventListener method on TSocket

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751021#comment-15751021 ] 

ASF GitHub Bot commented on THRIFT-4006:
----------------------------------------

GitHub user RomainThery opened a pull request:

    https://github.com/apache/thrift/pull/1140

    THRIFT-4006 Added removeEventListener method to TSocket.as

    No test provided as there is no test done for AS3 at the moment, but the change is pretty minor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RomainThery/thrift THRIFT-4006

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit 3367d473425abfa7fcc907eaa02c3beb3c8c28b1
Author: Romain Théry <rt...@ankama.com>
Date:   2016-12-15T10:20:05Z

    THRIFT-4006 Added removeEventListener method to TSocket.as

----


> Add a removeEventListener method on TSocket
> -------------------------------------------
>
>                 Key: THRIFT-4006
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4006
>             Project: Thrift
>          Issue Type: Improvement
>          Components: AS3 - Library
>    Affects Versions: 0.9.3
>            Reporter: Romain THERY
>            Priority: Minor
>
> For memory management, I wish I could remove event listeners I add to TSocket when I want and don't have to rely to weak references.
> I'll make a PR on github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)