You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/09/24 11:50:15 UTC
[GitHub] activemq-artemis pull request #795: Fix closing quorums on QuorumManager.sto...
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/795
Fix closing quorums on QuorumManager.stop
Just something I happened to notice in code while looking into something else. Not tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis quorum-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/795.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #795
----
commit 7f10b2abda3f3415e161df439d4f7e03f833ca86
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-09-24T11:48:36Z
Fix closing quorums on QuorumManager.stop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #795: Fix closing quorums on QuorumManager.sto...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/795#discussion_r80397054
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java ---
@@ -96,10 +96,10 @@ public void stop() throws Exception {
}
}
}
- quorums.clear();
for (Quorum quorum : quorums.values()) {
quorum.close();
}
+ quorums.clear();
--- End diff --
nice catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #795: Fix closing quorums on QuorumManager.sto...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---