[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4700: Make the formula to calculate the action time limit more configurable

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #4700: Make the formula to calculate the action time limit more configurable
URL: https://github.com/apache/openwhisk/pull/4700#discussion_r339724546
 
 

 ##########
 File path: ansible/group_vars/all
 ##########
 @@ -90,7 +90,7 @@ controller:
   managedFraction: "{{ controller_managed_fraction | default(1.0 - (controller_blackbox_fraction | default(__controller_blackbox_fraction))) }}"
   blackboxFraction: "{{ controller_blackbox_fraction | default(__controller_blackbox_fraction) }}"
   timeoutFactor: "{{ controller_timeout_factor | default(2) }}"
-  timeoutAddon: "{{ controller_timeout_addon | default(1) }}"
+  timeoutAddon: "{{ controller_timeout_addon | default('1 m') }}"
 
 Review comment:
   @sven-lange-last - Kubernetes uses the same mechanism of setting an environment variable like `CONFIG_whisk_loadbalancer_timeoutFactor` to override the default value that comes from loading `reference.conf`.  To make it easy to configure, you would add an entry into values.yaml (for example like this:https://github.com/apache/openwhisk-deploy-kube/blob/master/helm/openwhisk/values.yaml#L99) and use that entry in the `env` section of controller-pod.yaml (for example like this: https://github.com/apache/openwhisk-deploy-kube/blob/master/helm/openwhisk/templates/controller-pod.yaml#L132) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services