You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 20:12:54 UTC
[GitHub] [arrow] jonkeane opened a new pull request, #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
jonkeane opened a new pull request, #15229:
URL: https://github.com/apache/arrow/pull/15229
This allows for authenticated github calls during the builds which should prevent us from being ratelimited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #15229: GH-15228: [R][CI] Add GitHub PAT to jobs that are reaching limit [WIP]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1482188167
I have looked at this again and the issue is not trivial due to our use of archery, I will explain in the issue and close this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374160734
Revision: 45bd04a40cbe4e3973344b588549967ae1968bb1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dbae99430f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dbae99430f)
|Task|Status|
|----|------|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/3858675291/jobs/6577455744)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/3858674842/jobs/6577454977)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/3858674415/jobs/6577453989)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/3858674146/jobs/6577453374)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/3858673892/jobs/6577452815)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374157818
@github-actions crossbow submit test-r-depsource-system test-r-dev-duckdb test-r-ubuntu-22.04 test-r-gcc-11 test-r-gcc-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374084799
@github-actions crossbow submit test-r-depsource-system test-r-dev-duckdb test-r-ubuntu-22.04 test-r-gcc-11 test-r-gcc-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #15229:
URL: https://github.com/apache/arrow/pull/15229#discussion_r1063839002
##########
ci/docker/linux-apt-r.dockerfile:
##########
@@ -27,50 +27,53 @@ ENV R_PRUNE_DEPS=${r_prune_deps}
ARG r_duckdb_dev=FALSE
ENV R_DUCKDB_DEV=${r_duckdb_dev}
+ARG github_pat=""
Review Comment:
Cool, would you mind taking this over and doing the right thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374078706
* Closes: #15228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374078718
:warning: GitHub issue #15228 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374079472
@github-actions crossbow submit test-r-depsource-system test-r-dev-duckdb test-r-ubuntu-22.04 test-r-gcc-11 test-r-gcc-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser closed pull request #15229: GH-15228: [R][CI] Add GitHub PAT to jobs that are reaching limit [WIP]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser closed pull request #15229: GH-15228: [R][CI] Add GitHub PAT to jobs that are reaching limit [WIP]
URL: https://github.com/apache/arrow/pull/15229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374088661
Revision: f22ee35d2ccc3efe5188e8aaa75b2cd6e127cf6e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cdb9598c7e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cdb9598c7e)
|Task|Status|
|----|------|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/3858233875/jobs/6576524900)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/3858235129/jobs/6576527606)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/3858233595/jobs/6576524334)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/3858234476/jobs/6576526007)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/3858234824/jobs/6576526841)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15229:
URL: https://github.com/apache/arrow/pull/15229#issuecomment-1374080821
```
'github' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/3858199225
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #15229: GH-15228: [R] [CI] Add Github PAT to jobs that are reaching limit
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #15229:
URL: https://github.com/apache/arrow/pull/15229#discussion_r1063833523
##########
ci/docker/linux-apt-r.dockerfile:
##########
@@ -27,50 +27,53 @@ ENV R_PRUNE_DEPS=${r_prune_deps}
ARG r_duckdb_dev=FALSE
ENV R_DUCKDB_DEV=${r_duckdb_dev}
+ARG github_pat=""
Review Comment:
:x: this permanently embeds the pat into the image. This is not super dangerous for the crossbow builds as those PATs expire after the job is run but people do run these jobs locally and could have this envvar exported for use in their local R things. (Also it is just bad practice, maybe we need to use an non expiring pat for some reason at some point ...)
Here the first link explaining the issue + solution I found https://medium.com/marionete/pass-secure-information-for-building-docker-images-8adeafe08355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org