You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/03/01 19:38:51 UTC

[kudu-CR] [docs] Improvements to multi-master migration doc 

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9466


Change subject: [docs] Improvements to multi-master migration doc
......................................................................

[docs] Improvements to multi-master migration doc

- Add extra reminder to run as the Kudu user.

- Note that the copy_from_remote command requires authenticating
  to the remote service as the Kudu user.

- Note that the workflow can be used to migrate 2->3 masters by
  making straightforward adjustments to the procedure.

Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
---
M docs/administration.adoc
1 file changed, 21 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9466/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@215
PS1, Line 215: WARNING: The workflow is unsafe for adding new masters to an existing multi-master configuration,
             : with the one exception that it can be used, with obvious modifications, to migrate from two masters
             : to a multi-master configuration. Do not use it to add masters to a multi-master configuration with
             : three or more masters.
The WARNING seems like an odd place to note that 2->3 migrations are okay. Maybe just change this to:

The workflow is unsafe for adding new masters to an existing configuration that already has three or more masters. Do not use it for that purpose.

And then separately explain 2->3?


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@235
PS1, Line 235: data
FWIW, "data" here was supposed to mean "all on-disk data" rather than just "Kudu data blocks". But I understand that not everyone may read it that way, so your clarification makes sense.


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@236
PS1, Line 236: it
Nit: they


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@298
PS1, Line 298:   following command sequence, which should be run as the Kudu UNIX user, typically `kudu`:
We already have a WARNING at the top of the workflow to run everything as the 'kudu' user, so why note it on individual steps?

Alternatively, we could add "sudo -u kudu" to the beginning of every shell line if you think that would help.


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@353
PS1, Line 353: If your Kudu cluster is secure, in addition to running as the Kudu UNIX user (typically
             :   `kudu`), you must authenticate as the Kudu service user prior to running this command.
I think this would be more clear if broken up into two separate recommendations.



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 02 Mar 2018 19:48:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@297
PS2, Line 297: , which should be run as the Kudu UNIX user, typically `kudu`
> Given the addition of "sudo -u kudu" throughout (and the prior existence of
Done


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@354
PS2, Line 354: . If your Kudu cluster is secure, in addition to running as the Kudu UNIX user, you must
> Hmm, breaking it out like this will make it look like a separate step. What
Done


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@354
PS2, Line 354: . If your Kudu cluster is secure, in addition to running as the Kudu UNIX user, you must
> I agree, I think pushing this into a WARNING would read better. I'm not sur
I think how exactly to authenticate is out of scope and might depend on the user's environment. I don't want to start writing a Kerberos manual.


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@475
PS2, Line 475: $ kudu fs dump uuid --fs_wal_dir=<master_wal_dir> [--fs_data_dirs=<master_data_dirs>] 2>/dev/null
> Could you add "sudo -u kudu" to these steps too?
Done


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@534
PS2, Line 534: . Copy the master data to the replacement master with the following command:
> Need the authentication warning here too.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 16:52:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@631
PS3, Line 631: Congratulations, the masters have now been removed! To verify that all masters are working properly,
> Could you reformat this the same way you did the migration doc?
Done


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@654
PS3, Line 654: $ kudu cluster ksck master-01.example.com,master-02.example.com,master-03.example.com
> This (and the other ksck commands) should get a "sudo -u kudu".
Done


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@709
PS3, Line 709: === Changing Directory Configurations
> Could you bug Andrew to update this section? KUDU-2202 has been fixed and e
Done


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@754
PS3, Line 754: $ kudu fs update_dirs --fs_wal_dir=/wals --fs_data_dirs=/data/1,/data/2,/data/3
> And "sudo -u kudu" in these commands too.
Done


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@813
PS3, Line 813: // TODO(awong): revise this when KUDU-616 is complete.
> Could you bug Andrew about this too?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:48:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:56:09 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 3:

(5 comments)

In the vein of "no good deed goes unpunished"...

http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@631
PS3, Line 631: Congratulations, the masters have now been removed! To verify that all masters are working properly,
Could you reformat this the same way you did the migration doc?


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@654
PS3, Line 654: $ kudu cluster ksck master-01.example.com,master-02.example.com,master-03.example.com
This (and the other ksck commands) should get a "sudo -u kudu".


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@709
PS3, Line 709: === Changing Directory Configurations
Could you bug Andrew to update this section? KUDU-2202 has been fixed and even though KUDU-2117 is still open, the new --fs_metadata_dir flag means the "add" section should be updated.


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@754
PS3, Line 754: $ kudu fs update_dirs --fs_wal_dir=/wals --fs_data_dirs=/data/1,/data/2,/data/3
And "sudo -u kudu" in these commands too.


http://gerrit.cloudera.org:8080/#/c/9466/3/docs/administration.adoc@813
PS3, Line 813: // TODO(awong): revise this when KUDU-616 is complete.
Could you bug Andrew about this too?



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 19:09:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@354
PS2, Line 354: . If your Kudu cluster is secure, in addition to running as the Kudu UNIX user, you must
> Hmm, breaking it out like this will make it look like a separate step. What
I agree, I think pushing this into a WARNING would read better. I'm not sure if we have any documentation on this particular step. If we have some, maybe link it here, and if not, should we mention what this means from an administrative POV (running `kinit` or something)?



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 00:48:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Removed reviewer Kudu Jenkins.
-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9466

to look at the new patch set (#3).

Change subject: [docs] Improvements to multi-master migration doc
......................................................................

[docs] Improvements to multi-master migration doc

- Add extra reminder to run as the Kudu user.

- Note that the copy_from_remote command requires authenticating
  to the remote service as the Kudu user.

- Note that the workflow can be used to migrate 2->3 masters by
  making straightforward adjustments to the procedure.

- Move steps for verifying the migration was successful to a new
  section so they are more noticeable.

Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
---
M docs/administration.adoc
1 file changed, 38 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9466/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9466

to look at the new patch set (#4).

Change subject: [docs] Improvements to multi-master migration doc
......................................................................

[docs] Improvements to multi-master migration doc

- Add extra reminder to run as the Kudu user.

- Note that the copy_from_remote command requires authenticating
  to the remote service as the Kudu user.

- Note that the workflow can be used to migrate 2->3 masters by
  making straightforward adjustments to the procedure.

- Move steps for verifying the migration was successful to a new
  section so they are more noticeable.

Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
---
M docs/administration.adoc
1 file changed, 46 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9466/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@215
PS1, Line 215: WARNING: The workflow is unsafe for adding new masters to an existing multi-master configuration,
             : with the one exception that it can be used, with obvious modifications, to migrate from two masters
             : to a multi-master configuration. Do not use it to add masters to a multi-master configuration with
             : three or more masters.
> The WARNING seems like an odd place to note that 2->3 migrations are okay. 
Done


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@235
PS1, Line 235: data
> FWIW, "data" here was supposed to mean "all on-disk data" rather than just 
(thumbsup)


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@236
PS1, Line 236: it
> Nit: they
Done


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@298
PS1, Line 298:   following command sequence, which should be run as the Kudu UNIX user, typically `kudu`:
> We already have a WARNING at the top of the workflow to run everything as t
In my experience, people sometimes don't read those warnings, or they read them but it takes a bit to get to this part of the workflow and they forget, or they copy-paste the commands and then modify them with their dirs but forget to run the command as kudu. Probably adding sudo -u kudu is most helpful, so I will do that.


http://gerrit.cloudera.org:8080/#/c/9466/1/docs/administration.adoc@353
PS1, Line 353: If your Kudu cluster is secure, in addition to running as the Kudu UNIX user (typically
             :   `kudu`), you must authenticate as the Kudu service user prior to running this command.
> I think this would be more clear if broken up into two separate recommendat
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 23:31:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................

[docs] Improvements to multi-master migration doc

- Add extra reminder to run as the Kudu user.

- Note that the copy_from_remote command requires authenticating
  to the remote service as the Kudu user.

- Note that the workflow can be used to migrate 2->3 masters by
  making straightforward adjustments to the procedure.

- Move steps for verifying the migration was successful to a new
  section so they are more noticeable.

Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Reviewed-on: http://gerrit.cloudera.org:8080/9466
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M docs/administration.adoc
1 file changed, 46 insertions(+), 38 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Will Berkeley: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@297
PS2, Line 297: , which should be run as the Kudu UNIX user, typically `kudu`
Given the addition of "sudo -u kudu" throughout (and the prior existence of the WARNING up front), this is probably redundant.


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@354
PS2, Line 354: . If your Kudu cluster is secure, in addition to running as the Kudu UNIX user, you must
Hmm, breaking it out like this will make it look like a separate step. What if it were made into a WARNING? Would that look better?

If not, then merge it back into the previous step, as I think that's still better than this.


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@475
PS2, Line 475: $ kudu fs dump uuid --fs_wal_dir=<master_wal_dir> [--fs_data_dirs=<master_data_dirs>] 2>/dev/null
Could you add "sudo -u kudu" to these steps too?


http://gerrit.cloudera.org:8080/#/c/9466/2/docs/administration.adoc@534
PS2, Line 534: . Copy the master data to the replacement master with the following command:
Need the authentication warning here too.



-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 00:28:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9466

to look at the new patch set (#2).

Change subject: [docs] Improvements to multi-master migration doc
......................................................................

[docs] Improvements to multi-master migration doc

- Add extra reminder to run as the Kudu user.

- Note that the copy_from_remote command requires authenticating
  to the remote service as the Kudu user.

- Note that the workflow can be used to migrate 2->3 masters by
  making straightforward adjustments to the procedure.

- Move steps for verifying the migration was successful to a new
  section so they are more noticeable.

Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
---
M docs/administration.adoc
1 file changed, 32 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9466/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [docs] Improvements to multi-master migration doc

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9466 )

Change subject: [docs] Improvements to multi-master migration doc
......................................................................


Patch Set 4: Verified+1

Docs-only change.


-- 
To view, visit http://gerrit.cloudera.org:8080/9466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77ef796f8b35729871ef8ddf2b635989278c2ebc
Gerrit-Change-Number: 9466
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:58:05 +0000
Gerrit-HasComments: No