You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/02/15 22:03:58 UTC
Review Request 43585: Improvements and fixes for database check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
Bugs: AMBARI-15051
https://issues.apache.org/jira/browse/AMBARI-15051
Repository: ambari
Description
-------
– Log outputs to a separate file (this is already an ask from SmartSense)
– Use ERROR/WARNING/INFO to mark logs that fit the level
– Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
– Take in account fact that clusters count could be more then one in service config check
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
ambari-server/src/main/python/ambari_server/serverConfiguration.py ae9c51a
Diff: https://reviews.apache.org/r/43585/diff/
Testing
-------
tests will be added after review for this patch(draft)
Thanks,
Vitalyi Brodetskyi
Re: Review Request 43585: Improvements and fixes for database check
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/#review119244
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/checkDatabase.py (line 73)
<https://reviews.apache.org/r/43585/#comment180534>
I though that linux commands could only return 0 - 255 values.
I even tried this one, and get strangle results:
oozie@hn0-hwxtes:~$ exit 999
root@hn0-hwxtes:~# echo $?
231
Are you sure 999 works fine for you?
- Andrew Onischuk
On Feb. 15, 2016, 9:03 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43585/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 9:03 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15051
> https://issues.apache.org/jira/browse/AMBARI-15051
>
>
> Repository: ambari
>
>
> Description
> -------
>
> – Log outputs to a separate file (this is already an ask from SmartSense)
> – Use ERROR/WARNING/INFO to mark logs that fit the level
> – Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
> – Take in account fact that clusters count could be more then one in service config check
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
> ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py ae9c51a
>
> Diff: https://reviews.apache.org/r/43585/diff/
>
>
> Testing
> -------
>
> tests will be added after review for this patch(draft)
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43585: Improvements and fixes for database check
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/#review119249
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 15, 2016, 9:03 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43585/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 9:03 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15051
> https://issues.apache.org/jira/browse/AMBARI-15051
>
>
> Repository: ambari
>
>
> Description
> -------
>
> – Log outputs to a separate file (this is already an ask from SmartSense)
> – Use ERROR/WARNING/INFO to mark logs that fit the level
> – Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
> – Take in account fact that clusters count could be more then one in service config check
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
> ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py ae9c51a
>
> Diff: https://reviews.apache.org/r/43585/diff/
>
>
> Testing
> -------
>
> tests will be added after review for this patch(draft)
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43585: Improvements and fixes for database check
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/#review119333
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 16, 2016, 5:27 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43585/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 5:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15051
> https://issues.apache.org/jira/browse/AMBARI-15051
>
>
> Repository: ambari
>
>
> Description
> -------
>
> – Log outputs to a separate file (this is already an ask from SmartSense)
> – Use ERROR/WARNING/INFO to mark logs that fit the level
> – Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
> – Take in account fact that clusters count could be more then one in service config check
>
>
> Diffs
> -----
>
> ambari-server/conf/unix/log4j.properties c87b1f4
> ambari-server/conf/windows/log4j.properties 8a69508
> ambari-server/src/main/conf/log4j.properties 11e8d51
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
> ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
> ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java 1c2765c
> ambari-server/src/test/python/TestAmbariServer.py 511700b
>
> Diff: https://reviews.apache.org/r/43585/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43585: Improvements and fixes for database check
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/
-----------------------------------------------------------
(Updated Лют. 16, 2016, 5:27 після полудня)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
Changes
-------
Just fixed UT
Bugs: AMBARI-15051
https://issues.apache.org/jira/browse/AMBARI-15051
Repository: ambari
Description
-------
– Log outputs to a separate file (this is already an ask from SmartSense)
– Use ERROR/WARNING/INFO to mark logs that fit the level
– Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
– Take in account fact that clusters count could be more then one in service config check
Diffs (updated)
-----
ambari-server/conf/unix/log4j.properties c87b1f4
ambari-server/conf/windows/log4j.properties 8a69508
ambari-server/src/main/conf/log4j.properties 11e8d51
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java 1c2765c
ambari-server/src/test/python/TestAmbariServer.py 511700b
Diff: https://reviews.apache.org/r/43585/diff/
Testing (updated)
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 43585: Improvements and fixes for database check
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/#review119331
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 16, 2016, 5:07 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43585/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 5:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15051
> https://issues.apache.org/jira/browse/AMBARI-15051
>
>
> Repository: ambari
>
>
> Description
> -------
>
> – Log outputs to a separate file (this is already an ask from SmartSense)
> – Use ERROR/WARNING/INFO to mark logs that fit the level
> – Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
> – Take in account fact that clusters count could be more then one in service config check
>
>
> Diffs
> -----
>
> ambari-server/conf/unix/log4j.properties c87b1f4
> ambari-server/conf/windows/log4j.properties 8a69508
> ambari-server/src/main/conf/log4j.properties 11e8d51
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
> ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
> ambari-server/src/test/python/TestAmbariServer.py 511700b
>
> Diff: https://reviews.apache.org/r/43585/diff/
>
>
> Testing
> -------
>
> tests will be added after review for this patch(draft)
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43585: Improvements and fixes for database check
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43585/
-----------------------------------------------------------
(Updated Лют. 16, 2016, 5:07 після полудня)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Myroslav Papirkovskyy, and Sumit Mohanty.
Bugs: AMBARI-15051
https://issues.apache.org/jira/browse/AMBARI-15051
Repository: ambari
Description
-------
– Log outputs to a separate file (this is already an ask from SmartSense)
– Use ERROR/WARNING/INFO to mark logs that fit the level
– Either the python script or the system test validation code can parse the log file for ERROR and WARNING logs and post a summary - as Sunitha Velpula suggested.
– Take in account fact that clusters count could be more then one in service config check
Diffs (updated)
-----
ambari-server/conf/unix/log4j.properties c87b1f4
ambari-server/conf/windows/log4j.properties 8a69508
ambari-server/src/main/conf/log4j.properties 11e8d51
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java 9213738
ambari-server/src/main/python/ambari_server/checkDatabase.py af1d74f
ambari-server/src/test/python/TestAmbariServer.py 511700b
Diff: https://reviews.apache.org/r/43585/diff/
Testing
-------
tests will be added after review for this patch(draft)
Thanks,
Vitalyi Brodetskyi