You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/05/24 14:13:07 UTC

[activemq-artemis] 02/02: add some TODO notes

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git

commit 5d1be2c7b1ce008181b90ac0b88d7502061742ee
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Tue May 24 15:09:29 2022 +0100

    add some TODO notes
---
 .../protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java b/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
index 67b7f86d4e..41637712d5 100644
--- a/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
+++ b/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
@@ -134,7 +134,7 @@ public class AMQPMirrorControllerTarget extends ProtonAbstractReceiver implement
 
       @Override
       public void onError(int errorCode, String errorMessage) {
-         logger.warn("{}-{}", errorMessage, errorMessage);
+         logger.warn("{}-{}", errorMessage, errorMessage); //TODO: uses message twice, should use code + message?
       }
    }
 
@@ -433,7 +433,7 @@ public class AMQPMirrorControllerTarget extends ProtonAbstractReceiver implement
          duplicateIDCache = lruduplicateIDCache;
       } else {
          // we use the number of credits for the duplicate detection, as that means the maximum number of elements you can have pending
-         if (logger.isDebugEnabled()) {
+         if (logger.isDebugEnabled()) {//TODO: mismatch between check and log level
             logger.trace("Setting up duplicate detection cache on " + ProtonProtocolManager.MIRROR_ADDRESS + ", ServerID=" + internalMirrorID + " with " + connection.getAmqpCredits() + " elements, being the number of credits");
          }