You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2013/01/10 16:24:15 UTC
svn commit: r1431420 - /commons/proper/pool/trunk/findbugs-exclude-filter.xml
Author: markt
Date: Thu Jan 10 15:24:15 2013
New Revision: 1431420
URL: http://svn.apache.org/viewvc?rev=1431420&view=rev
Log:
Silence some false positives
Modified:
commons/proper/pool/trunk/findbugs-exclude-filter.xml
Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1431420&r1=1431419&r2=1431420&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Thu Jan 10 15:24:15 2013
@@ -22,6 +22,24 @@
put here to instruct Find Bugs to ignore them.
-->
<FindBugsFilter>
+ <!-- Swallowing exception is deliberate design choice -->
+ <Match>
+ <Or>
+ <Class name="org.apache.commons.pool2.PoolUtils$ErodingObjectPool" />
+ <Class name="org.apache.commons.pool2.PoolUtils$ErodingKeyedObjectPool" />
+ </Or>
+ <Or>
+ <Method name="invalidateObject" />
+ <Method name="close" />
+ </Or>
+ <Bug code="DE" />
+ </Match>
+ <!-- Exception is thrown and need to be caught -->
+ <Match>
+ <Class name="org.apache.commons.pool2.PoolUtils$KeyedObjectPoolMinIdleTimerTask" />
+ <Method name="run" />
+ <Bug code="REC" />
+ </Match>
<!-- Ignoring the exception is deliberate since an earlier exception is -->
<!-- more important. -->
<Match>
@@ -29,6 +47,8 @@
<Method name="borrowObject" />
<Bug code="DE" />
</Match>
+ <!-- Ignoring the exception is deliberate since an earlier exception is -->
+ <!-- more important. -->
<Match>
<Class name="org.apache.commons.pool2.impl.GenericObjectPool" />
<Method name="borrowObject" />