You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "YannByron (via GitHub)" <gi...@apache.org> on 2025/07/15 09:48:35 UTC
[PR] [hive] respect hive split.minsize/maxsize configs [paimon]
YannByron opened a new pull request, #5903:
URL: https://github.com/apache/paimon/pull/5903
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hive] respect hive split.minsize/maxsize configs [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy merged PR #5903:
URL: https://github.com/apache/paimon/pull/5903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hive] respect hive split.minsize/maxsize configs [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #5903:
URL: https://github.com/apache/paimon/pull/5903#discussion_r2207374847
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/utils/HiveSplitGenerator.java:
##########
@@ -51,7 +58,14 @@
/** Generator to generate hive input splits. */
public class HiveSplitGenerator {
- public static InputSplit[] generateSplits(FileStoreTable table, JobConf jobConf) {
+ private static final Logger LOG = LoggerFactory.getLogger(HiveSplitGenerator.class);
+ private static final String HIVE_PAIMON_RESPECT_MINMAXSPLITSIZE_ENABLED =
Review Comment:
Are these internal configs or are they exposed to users, If so, can you please explain this in the commit message
##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/utils/HiveSplitGenerator.java:
##########
@@ -136,4 +151,97 @@ private static Optional<Predicate> createPartitionPredicate(
partition, rowType, defaultPartName));
}
}
+
+ private static List<DataSplit> packSplits(
+ FileStoreTable table, JobConf jobConf, List<DataSplit> splits, int numSplits) {
+ if (table.coreOptions().deletionVectorsEnabled()) {
+ return splits;
+ }
+ long openCostInBytes =
+ jobConf.getLong(
+ HIVE_PAIMON_SPLIT_OPENFILECOST, table.coreOptions().splitOpenFileCost());
+ long splitSize = computeSplitSize(jobConf, splits, numSplits, openCostInBytes);
+ List<DataSplit> dataSplits = new ArrayList<>();
+ List<DataSplit> toPack = new ArrayList<>();
+ int numFiles = 0;
+ for (DataSplit split : splits) {
+ if (split.beforeFiles().isEmpty() && split.rawConvertible()) {
Review Comment:
Maybe need to consider `FallbackDataSplit` like https://github.com/apache/paimon/pull/5789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org