[GitHub] [hbase] saintstack commented on a change in pull request #1425: HBASE-24105 [Flakey Test] regionserver.TestRegionReplicas

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1425: HBASE-24105 [Flakey Test] regionserver.TestRegionReplicas
URL: https://github.com/apache/hbase/pull/1425#discussion_r402689774
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
 ##########
 @@ -117,9 +117,7 @@ public void process() throws IOException {
         HConstants.NO_SEQNUM, Procedure.NO_PROC_ID, -1, regionInfo));
 
       // Done!  Region is closed on this RS
-      this.rsServices.getRegionsInTransitionInRS().
-        remove(this.regionInfo.getEncodedNameAsBytes(), Boolean.FALSE);
-      LOG.debug("Closed {}" + region.getRegionInfo().getRegionNameAsString());
 
 Review comment:
   Hmm.. Is it the finally that is wrong?
   
   Here we remove only if value matches FALSE. The finally removes whatever the value.
   
   But I suppose no one else can add an entry while there is one in the map so the finally remove should be fine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services