You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 17:10:19 UTC
[GitHub] [arrow] kszucs opened a new pull request #7116: [CI] Fix R build matrix
kszucs opened a new pull request #7116:
URL: https://github.com/apache/arrow/pull/7116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7116: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#issuecomment-624783951
I do insist, thanks :) I'd rather have a workflow I can understand and debug and shoulder the burden of doing some things twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7116: ARROW-8721: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#discussion_r421083195
##########
File path: .github/workflows/r.yml
##########
@@ -110,6 +88,49 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-r
+ rstudio:
+ name: AMD64 CentOS 7 RStudio R 3.6
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ env:
+ R: 3.6
Review comment:
```suggestion
```
That env var isn't used in this image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7116: ARROW-8721: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#issuecomment-624816890
@nealrichardson updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7116: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#issuecomment-624777635
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7116: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#issuecomment-624780989
It's just a way to parametrize the docker-compose job. More and more steps needs to be repeated in the workflow files, so I think it's still better than duplicating the whole job definition.
If you insist I can separate it for you though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7116: ARROW-8721: [CI] Fix R build matrix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7116:
URL: https://github.com/apache/arrow/pull/7116#issuecomment-624816198
https://issues.apache.org/jira/browse/ARROW-8721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org