[GitHub] [incubator-mxnet] lebeg commented on a change in pull request #14504: Fixes for CI downloads

[GitBox <gi...@apache.org>]

lebeg commented on a change in pull request #14504: Fixes for CI downloads
URL: https://github.com/apache/incubator-mxnet/pull/14504#discussion_r268859815
 
 

 ##########
 File path: cpp-package/example/get_data.sh
 ##########
 @@ -14,29 +16,48 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-unameOut="$(uname -s)"
-case "${unameOut}" in
-    Linux*)     CMD='wget';;
-    Darwin*)    CMD='curl -o';;
-    CYGWIN*)    CMD='wget';;
-    MINGW*)     CMD='wget';;
-    *)          CMD=""
-esac
 
-if [ ! -d "./data" ]; then
-    mkdir data
-fi
+set -e
+
+mkdir -p data/mnist_data
+cd data/mnist_data
+
+download () {
 
 Review comment:
   The error was from incorrect `-o` supplied to the download function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services