You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Ivan Iliev (Jira)" <ji...@apache.org> on 2025/03/05 17:34:00 UTC
[jira] [Commented] (ARTEMIS-4710) Keep pem-keystore dependencies as is; make it really optional
[ https://issues.apache.org/jira/browse/ARTEMIS-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932701#comment-17932701 ]
Ivan Iliev commented on ARTEMIS-4710:
-------------------------------------
> Additionally, by avoiding a global import on PemKeyStoreProvider, and only referencing it upon use, those who wish would be able to exclude the dependency when the functionality is not used.
[This|https://github.com/apache/activemq-artemis/pull/4870/files#diff-3e7249ab66199105b0ab3a759558699bfc39ab7ff4a75311539d2618773f21adR358] does not work. The class still has to be loaded by the JVM the first time any reference to SSLSupport is made. Which is referred immediately upon enabling ssl on any acceptor. I am getting
{code:java}
Caused by: java.lang.NoClassDefFoundError: de/dentrassi/crypto/pem/PemKeyStoreProvider
at org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor.<init>(NettyAcceptor.java:294)
{code}
We do not need this dependency or functionality, we are not even using the default impls of org.apache.activemq.artemis.spi.core.remoting.ssl.SSLContextFactory.
> Keep pem-keystore dependencies as is; make it really optional
> -------------------------------------------------------------
>
> Key: ARTEMIS-4710
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4710
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.33.0
> Reporter: Alexey Markevich
> Priority: Minor
> Fix For: 2.34.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Previously we excluded bcprov-jdk15on and bcpkix-jdk15on dependencies normally used by pem-keystore, and replaced them with bcprov-jdk18on and bcpkix-jdk18on as already managed and used elsewhere in the build, thus keeping things consistent on a single gav for the bc modules.
> The latest 2.3.0 version of pem-keystore (used since ARTEMIS-4599) was actually changed to use bcprov-jdk18on and bcpkix-jdk18on in https://github.com/ctron/pem-keystore/commit/1263b207da0adf4a7d2dc61d6a9a19e7bba97731. As such we can now simplify the dependency handling by removing the prior exclusion+replacement handling for those deps.
> Additionally, by avoiding a global import on PemKeyStoreProvider, and only referencing it upon use, those who wish would be able to exclude the dependency when the functionality is not used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact