[GitHub] [geode] kirklund commented on a diff in pull request #7571: GEODE-10327: Overhaul GfshRule to kill processes and save artifacts for failures

[GitBox <gi...@apache.org>]

kirklund commented on code in PR #7571:
URL: https://github.com/apache/geode/pull/7571#discussion_r878590276


##########
geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/ServerStartupOnlineTest.java:
##########
@@ -116,13 +114,14 @@ public void startServerReturnsAfterStartupTaskCompletes() throws Exception {
   }
 
   @Test
-  public void statusServerReportsStartingUntilStartupTaskCompletes() throws Exception {
+  public void statusServerReportsStartingUntilStartupTaskCompletes()
+      throws InterruptedException, IOException {
     CompletableFuture<Void> startServerTask =
         executorServiceRule.runAsync(() -> gfshRule.execute(startServerCommand));
 
     waitForStartServerCommandToHang();
 
-    await().untilAsserted(() -> {
+    await().atMost(Duration.ofMinutes(1)).untilAsserted(() -> {

Review Comment:
   Remove `atMost` and use default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org