You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/06/18 20:44:04 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41622: [SPARK-44064][SQL] Move `NonFateSharingCache` from `core` module to `catalyst` module
dongjoon-hyun commented on code in PR #41622:
URL: https://github.com/apache/spark/pull/41622#discussion_r1233374951
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/util/NonFateSharingCache.scala:
##########
@@ -15,13 +15,15 @@
* limitations under the License.
*/
-package org.apache.spark.util
+package org.apache.spark.sql.util
Review Comment:
According to the code content, `NonFateSharingCache` fits `org.apache.spark.util` instead of `org.apache.spark.sql.util` because it's more general. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org