You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/06 09:38:02 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
tkalkirill opened a new pull request, #855:
URL: https://github.com/apache/ignite-3/pull/855
https://issues.apache.org/jira/browse/IGNITE-17107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
sashapolo commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890021807
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
Review Comment:
I guess it should simply be "Start a node"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
sashapolo commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890015355
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
+ * {@code ignite node start --config=$IGNITE_HOME/examples/config/ignite-config.json my-first-node}
+ * </li>
+ * <li>
+ * Cluster initialization using the CLI tool (if not done yet):<br>
+ * {@code ignite cluster init --cluster-name=ignite-cluster --node-endpoint=localhost:10300 --meta-storage-node=my-first-node}
+ * </li>
+ * <li>
+ * Add configuration for persistent data region of of the PageMemory storage engine using the CLI tool (if not done yet):<br>
+ * {@code ignite config set --type=cluster "pageMemory.regions.persistent:{persistent=true}"}
+ * </li>
+ * <li>Run the example in the IDE.</li>
+ * <li>
+ * Stop a server node using the CLI tool:<br>
Review Comment:
```suggestion
* Stop the server node using the CLI tool:<br>
```
##########
examples/src/integrationTest/java/org/apache/ignite/example/storage/ItPersistentPageMemoryStorageExampleTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import static org.apache.ignite.example.ExampleTestUtils.assertConsoleOutputContains;
+
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.example.AbstractExamplesTest;
+import org.apache.ignite.internal.storage.pagememory.configuration.schema.PageMemoryStorageEngineConfiguration;
+import org.junit.jupiter.api.Test;
+
+/**
+ * For {@link PersistentPageMemoryStorageExample} testing.
+ */
+public class ItPersistentPageMemoryStorageExampleTest extends AbstractExamplesTest {
Review Comment:
Why do we need a separate class for this? Can we use a single class with two methods? We could also extract the configuration into a helper method
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
Review Comment:
I don't think we have "server" nodes anymore...
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
+ * {@code ignite node start --config=$IGNITE_HOME/examples/config/ignite-config.json my-first-node}
+ * </li>
+ * <li>
+ * Cluster initialization using the CLI tool (if not done yet):<br>
+ * {@code ignite cluster init --cluster-name=ignite-cluster --node-endpoint=localhost:10300 --meta-storage-node=my-first-node}
+ * </li>
+ * <li>
+ * Add configuration for persistent data region of of the PageMemory storage engine using the CLI tool (if not done yet):<br>
+ * {@code ignite config set --type=cluster "pageMemory.regions.persistent:{persistent=true}"}
+ * </li>
+ * <li>Run the example in the IDE.</li>
+ * <li>
+ * Stop a server node using the CLI tool:<br>
Review Comment:
I guess this should also be applied to other tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890019830
##########
examples/src/integrationTest/java/org/apache/ignite/example/storage/ItPersistentPageMemoryStorageExampleTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import static org.apache.ignite.example.ExampleTestUtils.assertConsoleOutputContains;
+
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.example.AbstractExamplesTest;
+import org.apache.ignite.internal.storage.pagememory.configuration.schema.PageMemoryStorageEngineConfiguration;
+import org.junit.jupiter.api.Test;
+
+/**
+ * For {@link PersistentPageMemoryStorageExample} testing.
+ */
+public class ItPersistentPageMemoryStorageExampleTest extends AbstractExamplesTest {
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
sashapolo commented on PR #855:
URL: https://github.com/apache/ignite-3/pull/855#issuecomment-1147540870
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890018999
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
+ * {@code ignite node start --config=$IGNITE_HOME/examples/config/ignite-config.json my-first-node}
+ * </li>
+ * <li>
+ * Cluster initialization using the CLI tool (if not done yet):<br>
+ * {@code ignite cluster init --cluster-name=ignite-cluster --node-endpoint=localhost:10300 --meta-storage-node=my-first-node}
+ * </li>
+ * <li>
+ * Add configuration for persistent data region of of the PageMemory storage engine using the CLI tool (if not done yet):<br>
+ * {@code ignite config set --type=cluster "pageMemory.regions.persistent:{persistent=true}"}
+ * </li>
+ * <li>Run the example in the IDE.</li>
+ * <li>
+ * Stop a server node using the CLI tool:<br>
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes closed pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
SammyVimes closed pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
URL: https://github.com/apache/ignite-3/pull/855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
sashapolo commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890021807
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
Review Comment:
I guess it should simply be "Start a node" or "Start an Ignite node"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890019552
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
Review Comment:
And what do we have now? what to replace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes commented on pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
SammyVimes commented on PR #855:
URL: https://github.com/apache/ignite-3/pull/855#issuecomment-1147716013
Merged to the main branch https://github.com/apache/ignite-3/commit/02d795cefabae3e713bd3ba2accd25a090d2a10c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #855: IGNITE-17107 [Native Persistence 3.0] End-to-end test for persistent PageMemory
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #855:
URL: https://github.com/apache/ignite-3/pull/855#discussion_r890031714
##########
examples/src/main/java/org/apache/ignite/example/storage/PersistentPageMemoryStorageExample.java:
##########
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.example.storage;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.Statement;
+
+/**
+ * This example demonstrates a usage of the PageMemory storage engine configured with a persistent data region.
+ *
+ * <p>To run the example, do the following:
+ * <ol>
+ * <li>Import the examples project into you IDE.</li>
+ * <li>
+ * Download and prepare artifacts for running an Ignite node using the CLI tool (if not done yet):<br>
+ * {@code ignite init}
+ * </li>
+ * <li>
+ * Start a server node using the CLI tool:<br>
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org