You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@me.com> on 2014/01/27 12:40:21 UTC
Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Hi,
Really hard to review this given the amount of changes - most which seem while space?
Justin
RE: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Frédéric THOMAS <we...@hotmail.com>.
Np and thanks for the tip, anyway , I have been a bit quick to commit.
The fix is still applied, can you check on your side everything works as expected ?
Thanks,
Frédéric THOMAS
> Date: Mon, 27 Jan 2014 17:24:23 +0400
> From: alexander.doroshko@jetbrains.com
> To: dev@flex.apache.org
> Subject: Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062: FDB waits up to 20s per SWF before we can start debugging
>
> > The SVN change log have nothing to do with which IDE you use - you can
> > ignore whitespace changes in eclipse /flash builder as well but it
> > doesn't help in this case. Justin
>
> Ok, so Eclipse / Flash Builder + some SVN support plugin will do the
> same trick.
>
> No more flooding, sorry :)
Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Alexander Doroshko <al...@jetbrains.com>.
> The SVN change log have nothing to do with which IDE you use - you can
> ignore whitespace changes in eclipse /flash builder as well but it
> doesn't help in this case. Justin
Ok, so Eclipse / Flash Builder + some SVN support plugin will do the
same trick.
No more flooding, sorry :)
RE: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Frédéric THOMAS <we...@hotmail.com>.
Hi Justin,
Ok, maybe better I revert and re-commit only the fix
as and don't care about the useless, unused and confusing code, I'll do
it tonight, no time at the moment.
> I can see than addFrame return type was modified but is this really needed?
IIRC, addFrame was returning always true, I guess it was due to a partly removed code which then created confusion and was useless, so, I cleaned the code removing the useless return statement and the function signature, so, no it wasn't necessary.
Thanks,
Frédéric THOMAS
> Subject: Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062: FDB waits up to 20s per SWF before we can start debugging
> From: justinmclean@me.com
> Date: Tue, 28 Jan 2014 00:21:50 +1100
> To: dev@flex.apache.org
>
> Hi,
>
> And for instance another concerning change - I can see than addFrame return type was modified but is this really needed?
> - if (addFrame(c))
> - ++depth;
> -// System.out.println(" this="+id+",@"+(bpi&0xffff)+":"+(bpi>>16)+",stack="+stack);
> + addFrame(c);
> + ++depth;
>
> Justin
Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Justin Mclean <ju...@me.com>.
Hi,
And for instance another concerning change - I can see than addFrame return type was modified but is this really needed?
- if (addFrame(c))
- ++depth;
-// System.out.println(" this="+id+",@"+(bpi&0xffff)+":"+(bpi>>16)+",stack="+stack);
+ addFrame(c);
+ ++depth;
Justin
Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Justin Mclean <ju...@me.com>.
Hi,
> If you use IntelliJ IDEA - its Diff window has an option to ignore all changes in whitespaces.
The SVN change log have nothing to do with which IDE you use - you can ignore whitespace changes in eclipse /flash builder as well but it doesn't help in this case.
Justin
Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Alexander Doroshko <al...@jetbrains.com>.
If you use IntelliJ IDEA - its Diff window has an option to ignore all
changes in whitespaces.
On 27.01.2014 15:40, Justin Mclean wrote:
> Hi,
>
> Really hard to review this given the amount of changes - most which seem while space?
>
> Justin
RE: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062:
FDB waits up to 20s per SWF before we can start debugging
Posted by Frédéric THOMAS <we...@hotmail.com>.
Yes, there could be some white spaces too, I apologized already I committed the fix AND the code clean up, the more important changes are in DebugCLI though, relative to the waitForMetaData function, basically I removed its usage, the rest is code clean up.
Thanks,
Frédéric THOMAS
> Subject: Re: [4/4] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34062: FDB waits up to 20s per SWF before we can start debugging
> From: justinmclean@me.com
> Date: Mon, 27 Jan 2014 22:40:21 +1100
> To: dev@flex.apache.org
>
> Hi,
>
> Really hard to review this given the amount of changes - most which seem while space?
>
> Justin