You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2012/12/29 01:10:13 UTC
[jira] [Updated] (HBASE-7207) Consolidate snapshot related classes
into fewer packages
[ https://issues.apache.org/jira/browse/HBASE-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-7207:
----------------------------------
Attachment: pre-hbase-7207.patch
hbase-7207.patch
Massive but extremely boring patch.
All are renames or import fixes.
{code}
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/MasterAdminProtocol.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/CloneSnapshotHandler.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/MasterSnapshotVerifier.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotLogCleaner.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/manage/SnapshotManager.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/task/CopyRecoveredEditsTask.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CopyRecoveredEditsTask.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/CorruptedSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/CorruptedSnapshotException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/tool/ExportSnapshot.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/ExportSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshotException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/HBaseSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/HBaseSnapshotException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/task/ReferenceRegionHFilesTask.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ReferenceRegionHFilesTask.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/task/ReferenceServerWALsTask.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ReferenceServerWALsTask.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/RestoreSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/restore/RestoreSnapshotHelper.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/SnapshotCreationException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotCreationException.java
# modified: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/SnapshotDoesNotExistException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDoesNotExistException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/SnapshotExistsException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotExistsException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/restore/SnapshotLogSplitter.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotLogSplitter.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/task/SnapshotTask.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotTask.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/task/TableInfoCopyTask.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TableInfoCopyTask.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/TablePartiallyOpenException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TablePartiallyOpenException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/server/snapshot/TakeSnapshotUtils.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/UnexpectedSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/UnexpectedSnapshotException.java
# renamed: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/exception/UnknownSnapshotException.java -> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/UnknownSnapshotException.java
# modified: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java
# modified: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
# modified: hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java
# modified: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/manage/TestSnapshotManager.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java
# modified: hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/server/snapshot/task/TestCopyRecoveredEditsTask.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestCopyRecoveredEditsTask.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/tool/TestExportSnapshot.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/server/snapshot/task/TestReferenceRegionHFilesTask.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestReferenceRegionHFilesTask.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/restore/TestSnapshotLogSplitter.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotLogSplitter.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/server/snapshot/task/TestSnapshotTask.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotTask.java
# renamed: hbase-server/src/test/java/org/apache/hadoop/hbase/server/snapshot/task/TestWALReferenceTask.java -> hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestWALReferenceTask.java
#
{code}
> Consolidate snapshot related classes into fewer packages
> --------------------------------------------------------
>
> Key: HBASE-7207
> URL: https://issues.apache.org/jira/browse/HBASE-7207
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055, 0.96.0
>
> Attachments: hbase-7207.patch, pre-hbase-7207.patch
>
>
> The snapshot branch seems to have more packages with fewer classes present in each. We should consolidate them down to a core set. I'm suggesting limiting it to:
> o.a.h.h.errorhandling (move o.a.h.h.server.errorhandling.** to this package)
> o.a.h.h.procedure (eliminate procedure.member, procedure.coordinator, possibly add zk for the zk implementation)
> o.a.h.h.snapshot (move o.a.h.h.server.snapshots.** to this package)
> o.a.h.h.master.snapshot (fold subpackages in)
> o.a.h.h.regionserver.snapshot (fold subpackges in)
> Likely move all TestSnapshotFrom* to o.a.h.h.snapshot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira