You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/25 11:08:08 UTC
Review Request 38760: RANGER-645 : Make Tag DB store available on all
DB Flavors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38760/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-645
https://issues.apache.org/jira/browse/RANGER-645
Repository: ranger
Description
-------
Main changes :
* Added DB Schema for all the databases supported for Ranger
Other changes introduced :
1. Addition of columns has been moved in a separate db patch file 018-add-columns-tosupport-tag-based-policy.sql, while patch 016-updated-schema-for-tag-based-policy.sql will contain only new tables schema.
2. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
3. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
4. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
Diffs
-----
jisql/src/main/java/org/apache/util/sql/Jisql.java cf7563c7130660e405a952c388238d830d840fcb
security-admin/db/mysql/init/schema_mysql.sql 6df719558ab57a5145d1b04c1a5dbda103626f80
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 89c5cbe377d539c797a39b788920e859265286ab
security-admin/db/mysql/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
security-admin/db/mysql/patches/audit/011-auditcolumnssize.sql b38ae8c93c12fd44ea38977f1f029fee1c394a70
security-admin/db/mysql/patches/audit/015-auditlogaggregation.sql c88c5b414f363126a63dd536de1135c00667aae0
security-admin/db/mysql/xa_audit_db.sql 8334dced6d66f1b9042f2c41786f44fe1a5a9984
security-admin/db/mysql/xa_db.sql 9aba91fe6a9460fd19f5793bc367c4484e0c7953
security-admin/db/oracle/patches/009-updated_schema.sql ed472378bc20bb57421221330ae0c8b7f9ef023e
security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/oracle/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
security-admin/db/oracle/patches/audit/011-auditcolumnssize.sql 35a932042f14f1745a997d534caab4f1a97ac8c8
security-admin/db/oracle/patches/audit/015-auditlogaggregation.sql 756ee6177bd403689483a0d11e33bc4ac4c68de8
security-admin/db/oracle/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/oracle/xa_audit_db_oracle.sql 607a8b2a94e80ae862e203868d8d5716cfbc4662
security-admin/db/oracle/xa_core_db_oracle.sql 9c18ead44508c062360915c5678e4e91ce8d4ad8
security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/postgres/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
security-admin/db/postgres/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/postgres/xa_audit_db_postgres.sql cace5c580c9d52718f42a6a0cde215f054f47a5e
security-admin/db/postgres/xa_core_db_postgres.sql 123732e4a77b26ed8f0280f8ef04c05e746ea191
security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlanywhere/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlserver/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
security-admin/db/sqlserver/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
security-admin/db/sqlserver/xa_audit_db_sqlserver.sql 783b96832ae8979e58559c00137dbf8ca1f8b505
security-admin/db/sqlserver/xa_core_db_sqlserver.sql 6e304d4b2400e96e477186f97c2239cd41cf40de
security-admin/scripts/db_setup.py 1edc628d96d926309b720eb93eb44ee650fd1e46
security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java 868de4af0059c49f6ea751887ca768a02a652cc8
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 8fd3866b7a18c82c94ca9fa2fbfd184810ca5238
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java cd60736e08de4e7ec3d1399ad8a76523ec9d0623
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 77c83ec86189965eedcfe0db26b7dee44c70c2b0
security-admin/src/main/java/org/apache/ranger/entity/XXTag.java dd154b980c5e7608e9369a767da8f54e4afc30f4
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java cbbc1021f8e70f0eca11052a508d09cafeb3f4b2
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java acf6697305aa1963e36d7230e47c0c3af776dab3
security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 256522a557742be797f49a0c7a27b02f47acb98e
security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 98f2355e67a8288479e8268f07a70594feb1b8ba
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java df3fa1b773d9a5fd39e259cdac717e330fe97554
Diff: https://reviews.apache.org/r/38760/diff/
Testing
-------
Tested on a local centos instance with Ranger and different DB Flavors.
Thanks,
Gautam Borad
Re: Review Request 38760: RANGER-645 : Make Tag DB store available on
all DB Flavors
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38760/#review100650
-----------------------------------------------------------
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql (line 183)
<https://reviews.apache.org/r/38760/#comment157873>
tinyint(3) - would this limit the number of values for a resource to 8?
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql
<https://reviews.apache.org/r/38760/#comment157937>
I think it will help to keep all schema changes for tag-based-policy in a single script. Is there any specific reason to split this to 2 different scripts?
- Madhan Neethiraj
On Sept. 25, 2015, 9:08 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38760/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:08 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-645
> https://issues.apache.org/jira/browse/RANGER-645
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Main changes :
> * Added DB Schema for all the databases supported for Ranger
>
>
> Other changes introduced :
> 1. Addition of columns has been moved in a separate db patch file 018-add-columns-tosupport-tag-based-policy.sql, while patch 016-updated-schema-for-tag-based-policy.sql will contain only new tables schema.
> 2. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
> 3. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
> 4. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java cf7563c7130660e405a952c388238d830d840fcb
> security-admin/db/mysql/init/schema_mysql.sql 6df719558ab57a5145d1b04c1a5dbda103626f80
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 89c5cbe377d539c797a39b788920e859265286ab
> security-admin/db/mysql/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/mysql/patches/audit/011-auditcolumnssize.sql b38ae8c93c12fd44ea38977f1f029fee1c394a70
> security-admin/db/mysql/patches/audit/015-auditlogaggregation.sql c88c5b414f363126a63dd536de1135c00667aae0
> security-admin/db/mysql/xa_audit_db.sql 8334dced6d66f1b9042f2c41786f44fe1a5a9984
> security-admin/db/mysql/xa_db.sql 9aba91fe6a9460fd19f5793bc367c4484e0c7953
> security-admin/db/oracle/patches/009-updated_schema.sql ed472378bc20bb57421221330ae0c8b7f9ef023e
> security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/oracle/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/oracle/patches/audit/011-auditcolumnssize.sql 35a932042f14f1745a997d534caab4f1a97ac8c8
> security-admin/db/oracle/patches/audit/015-auditlogaggregation.sql 756ee6177bd403689483a0d11e33bc4ac4c68de8
> security-admin/db/oracle/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/oracle/xa_audit_db_oracle.sql 607a8b2a94e80ae862e203868d8d5716cfbc4662
> security-admin/db/oracle/xa_core_db_oracle.sql 9c18ead44508c062360915c5678e4e91ce8d4ad8
> security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/postgres/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/postgres/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/postgres/xa_audit_db_postgres.sql cace5c580c9d52718f42a6a0cde215f054f47a5e
> security-admin/db/postgres/xa_core_db_postgres.sql 123732e4a77b26ed8f0280f8ef04c05e746ea191
> security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlserver/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlserver/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/xa_audit_db_sqlserver.sql 783b96832ae8979e58559c00137dbf8ca1f8b505
> security-admin/db/sqlserver/xa_core_db_sqlserver.sql 6e304d4b2400e96e477186f97c2239cd41cf40de
> security-admin/scripts/db_setup.py 1edc628d96d926309b720eb93eb44ee650fd1e46
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java 868de4af0059c49f6ea751887ca768a02a652cc8
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 8fd3866b7a18c82c94ca9fa2fbfd184810ca5238
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java cd60736e08de4e7ec3d1399ad8a76523ec9d0623
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 77c83ec86189965eedcfe0db26b7dee44c70c2b0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java dd154b980c5e7608e9369a767da8f54e4afc30f4
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java cbbc1021f8e70f0eca11052a508d09cafeb3f4b2
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java acf6697305aa1963e36d7230e47c0c3af776dab3
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 256522a557742be797f49a0c7a27b02f47acb98e
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 98f2355e67a8288479e8268f07a70594feb1b8ba
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java df3fa1b773d9a5fd39e259cdac717e330fe97554
>
> Diff: https://reviews.apache.org/r/38760/diff/
>
>
> Testing
> -------
>
> Tested on a local centos instance with Ranger and different DB Flavors.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38760: RANGER-645 : Make Tag DB store available on
all DB Flavors
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38760/#review100678
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 25, 2015, 9:08 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38760/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:08 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-645
> https://issues.apache.org/jira/browse/RANGER-645
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Main changes :
> * Added DB Schema for all the databases supported for Ranger
>
>
> Other changes introduced :
> 1. Addition of columns has been moved in a separate db patch file 018-add-columns-tosupport-tag-based-policy.sql, while patch 016-updated-schema-for-tag-based-policy.sql will contain only new tables schema.
> 2. Newly required column 'options' of Table X_SERVICE_DEF is changed to 'def_options' as 'options' and 'option' are reserved keyword in SQL Anywhere.
> 3. Patch 015 which was using three alter statement to add three column, is now adjusted in one alter table statement. Similarly patch 011 also has been changed.
> 4. Sequence name has been changed with actual Sequence name used for Oracle/Postgres schema.
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java cf7563c7130660e405a952c388238d830d840fcb
> security-admin/db/mysql/init/schema_mysql.sql 6df719558ab57a5145d1b04c1a5dbda103626f80
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 89c5cbe377d539c797a39b788920e859265286ab
> security-admin/db/mysql/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/mysql/patches/audit/011-auditcolumnssize.sql b38ae8c93c12fd44ea38977f1f029fee1c394a70
> security-admin/db/mysql/patches/audit/015-auditlogaggregation.sql c88c5b414f363126a63dd536de1135c00667aae0
> security-admin/db/mysql/xa_audit_db.sql 8334dced6d66f1b9042f2c41786f44fe1a5a9984
> security-admin/db/mysql/xa_db.sql 9aba91fe6a9460fd19f5793bc367c4484e0c7953
> security-admin/db/oracle/patches/009-updated_schema.sql ed472378bc20bb57421221330ae0c8b7f9ef023e
> security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/oracle/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/oracle/patches/audit/011-auditcolumnssize.sql 35a932042f14f1745a997d534caab4f1a97ac8c8
> security-admin/db/oracle/patches/audit/015-auditlogaggregation.sql 756ee6177bd403689483a0d11e33bc4ac4c68de8
> security-admin/db/oracle/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/oracle/xa_audit_db_oracle.sql 607a8b2a94e80ae862e203868d8d5716cfbc4662
> security-admin/db/oracle/xa_core_db_oracle.sql 9c18ead44508c062360915c5678e4e91ce8d4ad8
> security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/postgres/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/postgres/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/postgres/xa_audit_db_postgres.sql cace5c580c9d52718f42a6a0cde215f054f47a5e
> security-admin/db/postgres/xa_core_db_postgres.sql 123732e4a77b26ed8f0280f8ef04c05e746ea191
> security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlanywhere/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlserver/patches/018-add-columns-tosupport-tag-based-policy.sql PRE-CREATION
> security-admin/db/sqlserver/patches/audit/017-add-new-column-to-store-tags.sql PRE-CREATION
> security-admin/db/sqlserver/xa_audit_db_sqlserver.sql 783b96832ae8979e58559c00137dbf8ca1f8b505
> security-admin/db/sqlserver/xa_core_db_sqlserver.sql 6e304d4b2400e96e477186f97c2239cd41cf40de
> security-admin/scripts/db_setup.py 1edc628d96d926309b720eb93eb44ee650fd1e46
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java 868de4af0059c49f6ea751887ca768a02a652cc8
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 8fd3866b7a18c82c94ca9fa2fbfd184810ca5238
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java cd60736e08de4e7ec3d1399ad8a76523ec9d0623
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 77c83ec86189965eedcfe0db26b7dee44c70c2b0
> security-admin/src/main/java/org/apache/ranger/entity/XXTag.java dd154b980c5e7608e9369a767da8f54e4afc30f4
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java cbbc1021f8e70f0eca11052a508d09cafeb3f4b2
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java acf6697305aa1963e36d7230e47c0c3af776dab3
> security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 256522a557742be797f49a0c7a27b02f47acb98e
> security-admin/src/main/java/org/apache/ranger/entity/XXTagResourceMap.java 98f2355e67a8288479e8268f07a70594feb1b8ba
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java df3fa1b773d9a5fd39e259cdac717e330fe97554
>
> Diff: https://reviews.apache.org/r/38760/diff/
>
>
> Testing
> -------
>
> Tested on a local centos instance with Ranger and different DB Flavors.
>
>
> Thanks,
>
> Gautam Borad
>
>