[GitHub] [incubator-superset] ktmud edited a comment on pull request #10161: build: dont prefer ts for cypress tests

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #10161:
URL: https://github.com/apache/incubator-superset/pull/10161#issuecomment-649681257


   > I feel like we should still prefer TS for all files (tests or not) but not force tests to be TS right away. What do you think? Note that this workflow doesn't block merging, this is an optional check
   
   I think it's OK to not require TypeScript for Cypress tests, as they seldom need typing. It does block merging, see: https://github.com/apache/incubator-superset/pull/10158 . Could be just a glitch though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org