[GitHub] wes3 commented on a change in pull request #1230: adp5061: Decode register fields in dump

[GitBox <gi...@apache.org>]

wes3 commented on a change in pull request #1230: adp5061: Decode register fields in dump
URL: https://github.com/apache/mynewt-core/pull/1230#discussion_r198874941
 
 

 ##########
 File path: hw/drivers/chg_ctrl/adp5061/src/adp5061_shell.c
 ##########
 @@ -27,16 +27,546 @@
 #include <shell/shell.h>
 #include <adp5061/adp5061.h>
 #include <parse/parse.h>
+#include <stdio.h>
 #include "adp5061_priv.h"
 
 static struct adp5061_dev *adp5061_dev;
 
+/*
+ * Struct for field name description.
+ * Used for argument validation and filed decoding
+ */
+struct reg_field
+{
+    /* Name of filed */
 
 Review comment:
   Was this supposed to be field instead of filed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services