You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/05 02:11:10 UTC

Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1641
    https://issues.apache.org/jira/browse/SQOOP-1641


Repository: sqoop-sqoop2


Description
-------

see jira as usual, nothing to talk about here.!


Diffs
-----

  docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 

Diff: https://reviews.apache.org/r/27603/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Nov. 4, 2014, 5:44 p.m., Gwen Shapira wrote:
> > Few typos, and I think you found an issue...

good catches! thanks for the quick reviews Gwen.


> On Nov. 4, 2014, 5:44 p.m., Gwen Shapira wrote:
> > docs/src/site/sphinx/Sqoop5MinutesDemo.rst, lines 182-185
> > <https://reviews.apache.org/r/27603/diff/1/?file=749916#file749916line182>
> >
> >     we don't output the dates anymore? Can you open a jira?

we do:) I removed it. will add it back


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/#review59910
-----------------------------------------------------------


On Nov. 4, 2014, 5:11 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27603/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 5:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1641
>     https://issues.apache.org/jira/browse/SQOOP-1641
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira as usual, nothing to talk about here.!
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 
> 
> Diff: https://reviews.apache.org/r/27603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/#review59910
-----------------------------------------------------------

Ship it!


Few typos, and I think you found an issue...


docs/src/site/sphinx/Sqoop5MinutesDemo.rst
<https://reviews.apache.org/r/27603/#comment101233>

    *the* help command



docs/src/site/sphinx/Sqoop5MinutesDemo.rst
<https://reviews.apache.org/r/27603/#comment101234>

    double : is intentional? a formatting thing?



docs/src/site/sphinx/Sqoop5MinutesDemo.rst
<https://reviews.apache.org/r/27603/#comment101235>

    hdfs://nameservice1:8020/
    
    (its the default for CDH...)



docs/src/site/sphinx/Sqoop5MinutesDemo.rst
<https://reviews.apache.org/r/27603/#comment101236>

    we don't output the dates anymore? Can you open a jira?


- Gwen Shapira


On Nov. 5, 2014, 1:11 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27603/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 1:11 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1641
>     https://issues.apache.org/jira/browse/SQOOP-1641
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira as usual, nothing to talk about here.!
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 
> 
> Diff: https://reviews.apache.org/r/27603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/#review59955
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Nov. 5, 2014, 4:53 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27603/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 4:53 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1641
>     https://issues.apache.org/jira/browse/SQOOP-1641
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira as usual, nothing to talk about here.!
> 
> 
> Diffs
> -----
> 
>   docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 
> 
> Diff: https://reviews.apache.org/r/27603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 8:53 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1641
    https://issues.apache.org/jira/browse/SQOOP-1641


Repository: sqoop-sqoop2


Description
-------

see jira as usual, nothing to talk about here.!


Diffs (updated)
-----

  docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 

Diff: https://reviews.apache.org/r/27603/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 8:45 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1641
    https://issues.apache.org/jira/browse/SQOOP-1641


Repository: sqoop-sqoop2


Description
-------

see jira as usual, nothing to talk about here.!


Diffs (updated)
-----

  docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 

Diff: https://reviews.apache.org/r/27603/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 27603: SQOOP-1641:Sqoop 5 minute demo.rst update to reflect latest in code

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27603/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 8:15 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1641
    https://issues.apache.org/jira/browse/SQOOP-1641


Repository: sqoop-sqoop2


Description
-------

see jira as usual, nothing to talk about here.!


Diffs (updated)
-----

  docs/src/site/sphinx/Sqoop5MinutesDemo.rst 920b051 

Diff: https://reviews.apache.org/r/27603/diff/


Testing
-------


Thanks,

Veena Basavaraj