You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jay Kreps (JIRA)" <ji...@apache.org> on 2015/02/07 22:51:34 UTC
[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with
o.a.k.common.utils.Utils
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Kreps updated KAFKA-1926:
-----------------------------
Description:
There is currently a lot of duplication between the Utils class in common and the one in core.
Our plan has been to deprecate duplicate code in the server and replace it with the new common code.
As such we should evaluate each method in the scala Utils and do one of the following:
1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose utility in active use that is not Kafka-specific. If we migrate it we should really think about the API and make sure there is some test coverage. A few things in there are kind of funky and we shouldn't just blindly copy them over.
2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold any utilities that really need to make use of Scala features to be convenient.
3. Delete it if it is not used, or has a bad api.
was:
There is currently a lot of duplication between the Utils class in common and the one in core.
Our plan has been to deprecate duplicate code in the server and replace it with the new common code.
As such we should evaluate each method in the scala Utils and do one of the following:
1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose utility that is not Kafka-specific. If we migrate it we should really think about the API and make sure there is some test coverage. A few things in there are kind of funky and we shouldn't just blindly copy them over.
2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold any utilities that really need to make use of Scala features to be convenient.
> Replace kafka.utils.Utils with o.a.k.common.utils.Utils
> -------------------------------------------------------
>
> Key: KAFKA-1926
> URL: https://issues.apache.org/jira/browse/KAFKA-1926
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jay Kreps
> Labels: newbie
>
> There is currently a lot of duplication between the Utils class in common and the one in core.
> Our plan has been to deprecate duplicate code in the server and replace it with the new common code.
> As such we should evaluate each method in the scala Utils and do one of the following:
> 1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose utility in active use that is not Kafka-specific. If we migrate it we should really think about the API and make sure there is some test coverage. A few things in there are kind of funky and we shouldn't just blindly copy them over.
> 2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold any utilities that really need to make use of Scala features to be convenient.
> 3. Delete it if it is not used, or has a bad api.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)