You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/22 17:06:07 UTC

[GitHub] [phoenix] priyankporwal commented on a change in pull request #806: PHOENIX-5946: Implement SchemaExtractionTool utility to get effective…

priyankporwal commented on a change in pull request #806:
URL: https://github.com/apache/phoenix/pull/806#discussion_r458947966



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##########
@@ -230,6 +254,7 @@
         private Boolean useStatsForParallelization;
         private long viewTTL;
         private long viewTTLHighWaterMark;
+        private Map<String, String> values = new HashMap<>();

Review comment:
       "values" seem like a bad name for maps that has both keys and values - how about "properties"? Looks like that's what are being put there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org