You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2018/08/27 17:15:19 UTC
[arrow] branch master updated: ARROW-3017: [C++] Don't throw
exception in arrow/util/thread-pool.h
This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new f841b90 ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h
f841b90 is described below
commit f841b9043ad4fe467f353cb7b5841be9ef6f1bbf
Author: Renato Marroquin <ma...@inf.ethz.ch>
AuthorDate: Mon Aug 27 19:15:14 2018 +0200
ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h
Simple patch for resolving https://issues.apache.org/jira/browse/ARROW-3017
Author: Renato Marroquin <ma...@inf.ethz.ch>
Closes #2472 from renato2099/ARROW-3017 and squashes the following commits:
c8ddaac4 <Renato Marroquin> ARROW-3017: Don't throw exception in arrow/util/thread-pool.h
---
cpp/src/arrow/util/thread-pool.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpp/src/arrow/util/thread-pool.h b/cpp/src/arrow/util/thread-pool.h
index 07bc5f9..c6c7071 100644
--- a/cpp/src/arrow/util/thread-pool.h
+++ b/cpp/src/arrow/util/thread-pool.h
@@ -25,6 +25,7 @@
#include <exception>
#include <functional>
#include <future>
+#include <iostream>
#include <list>
#include <memory>
#include <type_traits>
@@ -117,7 +118,8 @@ class ARROW_EXPORT ThreadPool {
Status st = SpawnReal(detail::packaged_task_wrapper<Result>(std::move(task)));
if (!st.ok()) {
// This happens when Submit() is called after Shutdown()
- throw std::runtime_error(st.ToString());
+ std::cerr << st.ToString() << std::endl;
+ std::abort();
}
return fut;
}