[GitHub] [incubator-datasketches-cpp] mdhimes commented on pull request #156: Add vector_of_kll_{floats,ints}_sketches to python

[GitBox <gi...@apache.org>]

mdhimes commented on pull request #156:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/156#issuecomment-640839804


   I agree with keeping it confined to Python, I'm not sure that there is much benefit (if any) to use this object with C++.
   
   I can see benefits to keeping it within the wrapper vs. separating it into another file.  It is, ultimately, a fancy wrapper for KLL, just written in a manner that is more optimized for Python.  However, it isn't actually a wrapper for KLL, since it's a new object + a Python wrapper for that new object.  I would say that a separate file would be best from an organizational point of view.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org