[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1278: [HUDI-573] Refactoring getter to avoid double extrametadata in json representation of HoodieCommitMetadata

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #1278: [HUDI-573] Refactoring getter to avoid double extrametadata in json representation of HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1278#discussion_r370946850
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
 ##########
 @@ -47,15 +47,15 @@
   protected Map<String, List<HoodieWriteStat>> partitionToWriteStats;
   protected Boolean compacted;
 
-  private Map<String, String> extraMetadataMap;
+  private Map<String, String> extraMetadata;
 
 Review comment:
   @n3nash : Is there anything we need to do to handle backwards compatibility with commit metadata written in older format. Would this change automatically handle that ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services