[GitHub] [incubator-pekko] mdedetrich commented on pull request #199: Add github PR check to make sure code is formatted

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #199:
URL: https://github.com/apache/incubator-pekko/pull/199#issuecomment-1432922427

   > In general, at least "Headers" and "Tests (pull_request)" should also be added.
   
   I am slightly wary in adding other checks right now because if you aren't careful you can freeze the github project (i.e. disallow any PR's from being merged) and you have to make an INFRA ticket to block it. For other checks we should test it out properly by making a dummy branch (as was done with incubator-pekko-sbt-paradox). The other issue here is if the name of the check changes unintentionally then we can get into this state.
   
   I am adding it for scalafmt now because that has close to zero change of ever needing to be changed and I am 100% sure it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org