[GitHub] rhtyd opened a new pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634
 
 
   This deprecates the vmware.ports.per.dvportgroup global setting.
   
   The vSphere Auto Expand feature (introduced in vSphere 5.0) will take
   care of dynamically increasing/decreasing the dvPorts when running out
   of distributed ports . But in case of vSphere 4.1/4.0 (If used), as this
   feature is not there, the new default value (=> 8) have an impact in the
   existing deployments. Action item for vSphere 4.1/4.0: Admin should
   modify the global configuration setting "vmware.ports.per.dvportgroup"
   from 8 to any number based on their environment because the proposal
   default value of 8 would be very less without auto expand feature in
   general. The current default value of 256 may not need immediate
   modification after deployment, but 8 would be very less which means
   admin need to update immediately after upgrade.
   
   This continues and take-over from PR https://github.com/apache/cloudstack/pull/1253
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   <!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   
   <!-- Fixes: # -->
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services