You are viewing a plain text version of this content. The canonical link for it is here.
Posted to doxia-dev@maven.apache.org by Vincent Siveton <vi...@gmail.com> on 2007/09/30 16:00:21 UTC

Re: svn commit: r580725 - /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java

Hi,

This fix is an important issue for report generation. I discussed on irc with
Dennis about that and he will deploy new snapshots to test again MPIR.
If everything will be ok, we think we need to release an alpha-10 of
doxia. What others think?

Cheers,

Vincent

2007/9/30, vsiveton@apache.org <vs...@apache.org>:
> Author: vsiveton
> Date: Sun Sep 30 06:37:06 2007
> New Revision: 580725
>
> URL: http://svn.apache.org/viewvc?rev=580725&view=rev
> Log:
> o fixed typo
>
> Modified:
>     maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
>
> Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
> URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java?rev=580725&r1=580724&r2=580725&view=diff
> ==============================================================================
> --- maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java (original)
> +++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java Sun Sep 30 06:37:06 2007
> @@ -861,7 +861,7 @@
>
>          if ( width != null )
>          {
> -            att.addAttribute( Attribute.COLSPAN, width );
> +            att.addAttribute( Attribute.WIDTH, width );
>          }
>
>          if ( justif != null )
>
>
>

Re: svn commit: r580725 - /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java

Posted by Dennis Lundberg <de...@apache.org>.
New are SNAPSHOTs deployed now.

Vincent Siveton wrote:
> Hi,
> 
> This fix is an important issue for report generation. I discussed on irc with
> Dennis about that and he will deploy new snapshots to test again MPIR.
> If everything will be ok, we think we need to release an alpha-10 of
> doxia. What others think?
> 
> Cheers,
> 
> Vincent
> 
> 2007/9/30, vsiveton@apache.org <vs...@apache.org>:
>> Author: vsiveton
>> Date: Sun Sep 30 06:37:06 2007
>> New Revision: 580725
>>
>> URL: http://svn.apache.org/viewvc?rev=580725&view=rev
>> Log:
>> o fixed typo
>>
>> Modified:
>>     maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
>>
>> Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
>> URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java?rev=580725&r1=580724&r2=580725&view=diff
>> ==============================================================================
>> --- maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java (original)
>> +++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java Sun Sep 30 06:37:06 2007
>> @@ -861,7 +861,7 @@
>>
>>          if ( width != null )
>>          {
>> -            att.addAttribute( Attribute.COLSPAN, width );
>> +            att.addAttribute( Attribute.WIDTH, width );
>>          }
>>
>>          if ( justif != null )
>>
>>
>>
> 


-- 
Dennis Lundberg

Re: svn commit: r580725 - /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java

Posted by Lukas Theussl <lt...@apache.org>.
I have reverted the whole patch at DOXIA-78 (it also affected the 
XdocParser), and also my erroneous javadoc comments in the Sink. If you 
want to go for an alpha-10, you should merge those changes into the branch.

-Lukas


Vincent Siveton wrote:
> Hi,
> 
> This fix is an important issue for report generation. I discussed on irc with
> Dennis about that and he will deploy new snapshots to test again MPIR.
> If everything will be ok, we think we need to release an alpha-10 of
> doxia. What others think?
> 
> Cheers,
> 
> Vincent
> 
> 2007/9/30, vsiveton@apache.org <vs...@apache.org>:
> 
>>Author: vsiveton
>>Date: Sun Sep 30 06:37:06 2007
>>New Revision: 580725
>>
>>URL: http://svn.apache.org/viewvc?rev=580725&view=rev
>>Log:
>>o fixed typo
>>
>>Modified:
>>    maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
>>
>>Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java
>>URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java?rev=580725&r1=580724&r2=580725&view=diff
>>==============================================================================
>>--- maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java (original)
>>+++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlSink.java Sun Sep 30 06:37:06 2007
>>@@ -861,7 +861,7 @@
>>
>>         if ( width != null )
>>         {
>>-            att.addAttribute( Attribute.COLSPAN, width );
>>+            att.addAttribute( Attribute.WIDTH, width );
>>         }
>>
>>         if ( justif != null )
>>
>>
>>