You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/10/26 03:39:33 UTC

[GitHub] cjolivier01 commented on a change in pull request #8435: C++ Framework and validation tests for operator validation and performance

cjolivier01 commented on a change in pull request #8435: C++ Framework and validation tests for operator validation and performance
URL: https://github.com/apache/incubator-mxnet/pull/8435#discussion_r147039670
 
 

 ##########
 File path: src/c_api/c_api_ndarray.cc
 ##########
 @@ -35,59 +35,10 @@
 #include "./c_api_common.h"
 #include "../common/utils.h"
 #include "../common/exec_utils.h"
+#include "../imperative/imperative_utils.h"
 
 using namespace mxnet;
 
-nnvm::NodeAttrs ParseAttrs(const nnvm::Op *op,
 
 Review comment:
   These are moved to imperative_utils.h.  I added documentation in the header.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services