You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/09/03 20:17:34 UTC

[commons-lang] branch master updated (4632ad7 -> 25d89e7)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git.


    from 4632ad7  Update spotbugs-maven-plugin to version 3.1.12.2.
     new 8757d91  Sort members.
     new 25d89e7  No need to nest in else clause.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../apache/commons/lang3/exception/ExceptionUtils.java   | 16 ++++++++--------
 .../apache/commons/lang3/text/ExtendedMessageFormat.java |  3 +--
 2 files changed, 9 insertions(+), 10 deletions(-)


[commons-lang] 01/02: Sort members.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit 8757d91bc3e5fa6a4a01bf3c16e39e2a75f28e72
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Sep 3 14:08:00 2019 -0400

    Sort members.
---
 .../apache/commons/lang3/exception/ExceptionUtils.java   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
index e9761cd..be5a7a2 100644
--- a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
+++ b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
@@ -40,14 +40,6 @@ import org.apache.commons.lang3.Validate;
 public class ExceptionUtils {
 
     /**
-     * <p>Used when printing stack frames to denote the start of a
-     * wrapped exception.</p>
-     *
-     * <p>Package private for accessibility by test suite.</p>
-     */
-    static final String WRAPPED_MARKER = " [wrapped] ";
-
-    /**
      * <p>The names of methods commonly used to access a wrapped exception.</p>
      */
     // TODO: Remove in Lang 4.0
@@ -66,6 +58,14 @@ public class ExceptionUtils {
         "getThrowable",
     };
 
+    /**
+     * <p>Used when printing stack frames to denote the start of a
+     * wrapped exception.</p>
+     *
+     * <p>Package private for accessibility by test suite.</p>
+     */
+    static final String WRAPPED_MARKER = " [wrapped] ";
+
     //-----------------------------------------------------------------------
     /**
      * <p>Introspects the <code>Throwable</code> to obtain the cause.</p>


[commons-lang] 02/02: No need to nest in else clause.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit 25d89e78f0fe359abbb8b3e12b29820d7f7d52a2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Sep 3 16:17:30 2019 -0400

    No need to nest in else clause.
---
 src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java b/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
index bdf4137..625dcf9 100644
--- a/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
+++ b/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
@@ -491,9 +491,8 @@ public class ExtendedMessageFormat extends MessageFormat {
                 next(pos);
                 return appendTo == null ? null : appendTo.append(c, lastHold,
                         pos.getIndex() - lastHold);
-            } else {
-                next(pos);
             }
+            next(pos);
         }
         throw new IllegalArgumentException(
                 "Unterminated quoted string at position " + start);