You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Abhinandan Prateek <ap...@apache.org> on 2015/01/19 04:31:58 UTC
Review Request 30020: CLOUDSTACK-8164: Look for all host to avoid NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30020/
-----------------------------------------------------------
Review request for cloudstack and Rohit Yadav.
Bugs: CLOUDSTACK-8164
https://issues.apache.org/jira/browse/CLOUDSTACK-8164
Repository: cloudstack-git
Description
-------
CLOUDSTACK-8164: Look for all host to avoid NPE
Diffs
-----
engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java a1bcd45d3a20dd8965d3aa4cb8f630d7eb0b13f9
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java 6590a748a31647d5bc83f48d140a04d90bedb068
Diff: https://reviews.apache.org/r/30020/diff/
Testing
-------
Tested, a proper error is now shown when the snapshot on disabled host is deleted instead of NPE.
Thanks,
Abhinandan Prateek
Re: Review Request 30020: CLOUDSTACK-8164: Look for all host to avoid
NPE
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30020/#review68588
-----------------------------------------------------------
Ship it!
LGTM. Merging.
- Rohit Yadav
On Jan. 19, 2015, 3:31 a.m., Abhinandan Prateek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30020/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2015, 3:31 a.m.)
>
>
> Review request for cloudstack and Rohit Yadav.
>
>
> Bugs: CLOUDSTACK-8164
> https://issues.apache.org/jira/browse/CLOUDSTACK-8164
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-8164: Look for all host to avoid NPE
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java a1bcd45d3a20dd8965d3aa4cb8f630d7eb0b13f9
> server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java 6590a748a31647d5bc83f48d140a04d90bedb068
>
> Diff: https://reviews.apache.org/r/30020/diff/
>
>
> Testing
> -------
>
> Tested, a proper error is now shown when the snapshot on disabled host is deleted instead of NPE.
>
>
> Thanks,
>
> Abhinandan Prateek
>
>