You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/04 13:05:17 UTC
Review Request 45674: Implemented recover() for dvd isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description
-------
Implemented recover() for dvd isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45674/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130011
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 121)
<https://reviews.apache.org/r/45674/#comment193619>
add apace before `should`
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 122 - 124)
<https://reviews.apache.org/r/45674/#comment193620>
Let's add a VLOG(1).
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 223)
<https://reviews.apache.org/r/45674/#comment193621>
ditto.
- Gilbert Song
On April 21, 2016, 2:13 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 2:13 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review129870
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46245, 45373, 45326, 45270, 46426, 46428, 45360, 46180, 45370, 45375, 45674]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 21, 2016, 9:13 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 9:13 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Jie Yu <yu...@gmail.com>.
> On April 24, 2016, 5:52 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 133-134
> > <https://reviews.apache.org/r/45674/diff/4/?file=1358482#file1358482line133>
> >
> > Let's quote the containerId.
We don't quote containerId because it's generated by Mesos.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130315
-----------------------------------------------------------
On April 23, 2016, 8:20 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 8:20 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130315
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 133 - 134)
<https://reviews.apache.org/r/45674/#comment194027>
Let's quote the containerId.
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 157 - 158)
<https://reviews.apache.org/r/45674/#comment194028>
ditto.
- Gilbert Song
On April 23, 2016, 1:20 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 1:20 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130320
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 23, 2016, 8:20 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 8:20 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/
-----------------------------------------------------------
(Updated 四月 23, 2016, 8:20 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description
-------
Implemented recover() for dvd isolator.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
Diff: https://reviews.apache.org/r/45674/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 22, 2016, 10:20 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 181-185
> > <https://reviews.apache.org/r/45674/diff/3/?file=1356492#file1356492line181>
> >
> > Please do not copy the comments blindly. The comments here does not apply to this isolator. Please remove it.
Seems this comment also fit to the `_recover` here well, as the `_recover` is also adding `Info` to `infos` and will not add it if the checkpoint directory was deleted.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130197
-----------------------------------------------------------
On 四月 22, 2016, 7:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated 四月 22, 2016, 7:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130197
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 120 - 121)
<https://reviews.apache.org/r/45674/#comment193897>
Copy paste error? Please remove the comments here.
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 181 - 185)
<https://reviews.apache.org/r/45674/#comment193900>
Please do not copy the comments blindly. The comments here does not apply to this isolator. Please remove it.
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 218)
<https://reviews.apache.org/r/45674/#comment193903>
no need to introduce a separate file and parse funcition. Simply put the parsing logic here.
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 225)
<https://reviews.apache.org/r/45674/#comment193907>
s/dockerVolumes/volumes/
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 227)
<https://reviews.apache.org/r/45674/#comment193908>
This is no longer needed per my comments in ealier patches.
- Jie Yu
On April 22, 2016, 7:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 7:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 22, 2016, 7:41 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 171
> > <https://reviews.apache.org/r/45674/diff/3/?file=1356492#file1356492line171>
> >
> > Should wait for cleanup before return like:
> > ```
> > list<Future<Nothing>> futures;
> > foreach (const ContainerID& containerId, unknownOrphans) {
> > futures.push_back(cleanup(containerId));
> > }
> >
> > return collect(futures)
> > .then([]() -> Future<Nothing> { return Nothing(); });
> > ```
What would be the problem if did not wait for clean up here? The `cleanup()` already have some logic handling wait logic for `unmount`.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130052
-----------------------------------------------------------
On 四月 22, 2016, 7:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated 四月 22, 2016, 7:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review130052
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 171)
<https://reviews.apache.org/r/45674/#comment193671>
Should wait for cleanup before return like:
```
list<Future<Nothing>> futures;
foreach (const ContainerID& containerId, unknownOrphans) {
futures.push_back(cleanup(containerId));
}
return collect(futures)
.then([]() -> Future<Nothing> { return Nothing(); });
```
- haosdent huang
On April 22, 2016, 7:15 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 7:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
> src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
> src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
> src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/
-----------------------------------------------------------
(Updated 四月 22, 2016, 7:15 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description
-------
Implemented recover() for dvd isolator.
Diffs (updated)
-----
src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45674/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/
-----------------------------------------------------------
(Updated 四月 21, 2016, 9:13 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description
-------
Implemented recover() for dvd isolator.
Diffs (updated)
-----
src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327
src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
src/slave/containerizer/mesos/isolators/docker/volume/state.hpp bc0c3299f9f3e351aaa20652b784bccbfd40c1a5
src/slave/containerizer/mesos/isolators/docker/volume/state.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45674/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45674: Implemented recover() for dvd isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/#review126821
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45214, 45217, 45265, 45270, 45360, 45373, 45370, 45375, 45377, 45326, 44454, 45671, 45674]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 4, 2016, 11:05 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45674/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 11:05 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() for dvd isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45674/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>