You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2023/06/16 12:50:57 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request, #2100: TINKERPOP-2920 Fixed bug in SubgraphStrategy when key not present

spmallette opened a new pull request, #2100:
URL: https://github.com/apache/tinkerpop/pull/2100

   https://issues.apache.org/jira/browse/TINKERPOP-2920
   
   `ProductiveByStrategy` was interacting badly with `SubgraphStrategy` and altering a child traversal in `PropertyMapStep` that it probably shouldn't have been.
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] Cole-Greer commented on pull request #2100: TINKERPOP-2920 Fixed bug in SubgraphStrategy when key not present

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2100:
URL: https://github.com/apache/tinkerpop/pull/2100#issuecomment-1595224166

   LGTM VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] spmallette merged pull request #2100: TINKERPOP-2920 Fixed bug in SubgraphStrategy when key not present

Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette merged PR #2100:
URL: https://github.com/apache/tinkerpop/pull/2100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] codecov-commenter commented on pull request #2100: TINKERPOP-2920 Fixed bug in SubgraphStrategy when key not present

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2100:
URL: https://github.com/apache/tinkerpop/pull/2100#issuecomment-1594638716

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2100](https://app.codecov.io/gh/apache/tinkerpop/pull/2100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fed6725) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/98d24d0dc1332e547e5acfefa4db3b5219a5d1ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (98d24d0) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.5-dev    #2100      +/-   ##
   =============================================
   + Coverage      69.86%   69.88%   +0.02%     
   =============================================
     Files            865       24     -841     
     Lines          40964     3457   -37507     
     Branches        5447        0    -5447     
   =============================================
   - Hits           28620     2416   -26204     
   + Misses         10434      863    -9571     
   + Partials        1910      178    -1732     
   ```
   
   
   [see 841 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2100/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org