You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by aniruddhas <gi...@git.apache.org> on 2015/09/25 11:11:20 UTC

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

GitHub user aniruddhas opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/84

    Fixed JavaDoc Placement for AsyncFSStorageAgent

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aniruddhas/incubator-apex-core release-3.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 23b63414dad1fe5dff8a0a8699a65f9fe067d472
Author: Aniruddha Thombre <an...@aniruddhas.com>
Date:   2015-09-25T09:05:12Z

    Fixed JavaDoc Placement for AsyncFSStorageAgent

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/84#issuecomment-146640926
  
    Please squash the commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by MalharJenkins <gi...@git.apache.org>.
Github user MalharJenkins commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/84#issuecomment-146470781
  
    Please, let me know if this is acceptable.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/84#issuecomment-148576654
  
    Change is made. Please close pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by aniruddhas <gi...@git.apache.org>.
Github user aniruddhas commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/84#discussion_r40662272
  
    --- Diff: common/src/main/java/com/datatorrent/common/util/AsyncFSStorageAgent.java ---
    @@ -30,6 +27,13 @@
     import org.slf4j.LoggerFactory;
     
     import com.datatorrent.netlet.util.DTThrowable;
    +
    +/**
    + * <p>AsyncFSStorageAgent class.</p>
    + *
    + * @since 3.1.0
    + */
    +
    --- End diff --
    
    That section was manually created as the tool was adding the tag at the start of the java file.
    I'll remove the blank lines if required and open another pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by aniruddhas <gi...@git.apache.org>.
Github user aniruddhas closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: Fixed JavaDoc Placement for Asyn...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/84#issuecomment-144036983
  
    @aniruddhas Any update?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---